stage-1: Detect hung tasks and abort boot #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure applet might be re-designed a bit soon, so don't worry about its appearance. And if you worry about it, please provide a better implementation! |
samueldr
force-pushed
the
feature/stage-1-hung-tasks
branch
from
2bd4353
to
c38baab
Compare
- exit after everything happened, just in case - exit the progress display - allow a custom delay to be set
It's a Files dependency, but with just a bit more user friendliness when used in an error message.
The way we're handling them is to have a global timer that is reset at any point a task is ran. This gives a maximum amount of chances to any task to have its dependencies resolve. A minimum of 60s is given, but in reality the chances are the conditions for trying to resolve were already present before the timeout started counting towards that particular dependency. Note that a long running task, when successfully ran, does not cause the timeout to be reached. E.g. at 10s of timeout a task is started, the loop is not executed until the task exits. When it exits the branch followed is for a task that ran, which means that even if the task took 70s total (which gives us 80 seconds) a timeout of 60s wouldn't apply here. Though, please, don't make your tasks take that much time to run!
samueldr
force-pushed
the
feature/stage-1-hung-tasks
branch
from
c38baab
to
00f81fa
Compare
|
When I tested #234 on device, it was actually tested with this PR. I will add that this was successfully faiiling the boot in a useful way when I broke my Pinephone setup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #234
With this PR, the boot is aborted when no tasks can be run for a given amount of time.
The test case I used for this is to produce the
demoimage with a badfilesystems."/".device.This is representative enough of someone not flashing the rootfs on their device.
The user experience is as follows:
This is not ideal, it would be great to somehow be able to resolve this to better error messages, BUT, we have all the information right in there for the end-user. So while it's not the best UX possible, it's the better option, being totally transparent.