Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.emv: init at 1.0.11 #102846

Merged
merged 1 commit into from Nov 24, 2020
Merged

python3Packages.emv: init at 1.0.11 #102846

merged 1 commit into from Nov 24, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 5, 2020 •
edited

Motivation for this change

Add emv (which includes the emvtool CLI, but really it's useful independently as a library).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 5, 2020 •
edited

Result of nixpkgs-review pr 102846 run on x86_64-linux 1

1 package failed to build:
  • python27Packages.python-emv
2 packages built:
  • python37Packages.python-emv
  • python38Packages.python-emv
ERROR: Package 'emv' requires a different Python: 2.7.18 not in '>=3.4'

@lukegb lukegb changed the title pythonPackages.python-emv: init at 1.0.9 python3Packages.emv: init at 1.0.9 Nov 5, 2020
@lukegb
Copy link
Contributor Author

lukegb commented Nov 5, 2020

Result of nixpkgs-review pr 102846 run on x86_64-linux 1

1 package failed to build:
2 packages built:

ERROR: Package 'emv' requires a different Python: 2.7.18 not in '>=3.4'

Should be fixed; rerunning nixpkgs-review locally now. Renamed the attr to just "emv", since that's what it's called on pypi.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 5, 2020

Seems to have built, can't be bothered to configure nixpkgs-review with a GH token.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102846 run on x86_64-darwin 1

2 packages built:
  • python37Packages.emv
  • python38Packages.emv

jonringer
jonringer reviewed Nov 7, 2020
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/emv/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/emv/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/emv/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/emv/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/emv/default.nix Outdated Show resolved Hide resolved
@lukegb lukegb requested a review from jonringer November 8, 2020 01:13
@lukegb lukegb changed the title python3Packages.emv: init at 1.0.9 python3Packages.emv: init at 1.0.11 Nov 8, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102846 run on x86_64-linux 1

2 packages built:
  • python37Packages.emv
  • python38Packages.emv

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 24, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102846 run on x86_64-darwin 1

with #104823 applied locally

2 packages built:
  • python37Packages.emv
  • python38Packages.emv

@SuperSandro2000 SuperSandro2000 merged commit 2ab19d9 into NixOS:master Nov 24, 2020
@lukegb lukegb deleted the python-emv branch December 5, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @SuperSandro2000 @jonringer