Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zfs: remove unused forceImportAll option #102809

Closed
wants to merge 1 commit into from
Closed

nixos/zfs: remove unused forceImportAll option #102809

wants to merge 1 commit into from

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Nov 4, 2020

Motivation for this change

It looks like its functionality was (possibly accidentally) removed in #42269

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Taneb
nixos/zfs: remove unused forceImportAll option
740fccc 
It looks like its functionality was (possibly accidentally) removed in NixOS#42269
@rissson
Copy link
Member

rissson commented Nov 7, 2020

Can you add a mkRemovedOptionModule with a small message letting the users know why this was removed?

@deviant
Copy link
Member

deviant commented May 6, 2021

This no longer seems to be true as of #95751.

@Taneb
Copy link
Contributor Author

Taneb commented May 6, 2021

This no longer seems to be true as of #95751.

That seems to be correct. I'll close this issue

@Taneb Taneb closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taneb @rissson @deviant @SuperSandro2000