Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] undervolt: expose power limits as Nixopts #102215

Merged
merged 1 commit into from Dec 1, 2020
Merged

[20.09] undervolt: expose power limits as Nixopts #102215

merged 1 commit into from Dec 1, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Oct 31, 2020

Motivation for this change

#95011 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
undervolt: expose power limits as Nixopts
dfce71f 
We no longer escape the flags because the power limit flags want two arguments
If we escaped them, we'd only get one argument with an escaped space in it.

Undervolt's flags don't have anything in them that would need to be escaped, so
that shouldn't break anything

(cherry picked from commit eb4e675)
@Atemu
Copy link
Member Author

Atemu commented Nov 30, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 30, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

bennyandresen
bennyandresen approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@bennyandresen bennyandresen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
And this change is already in master.

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau December 1, 2020 11:28
@Atemu
Copy link
Member Author

Atemu commented Dec 1, 2020

And this change is already in master.

What do you mean by that?

@bennyandresen
Copy link
Contributor

And this change is already in master.

What do you mean by that?

I reviewed this before I realized it was a backport and it looked good to me.
Then saw that it's already in nixos-unstable (=master) and already received discussion before.

Conclusion: I'm good with this change and would merge it.

@Atemu
Copy link
Member Author

Atemu commented Dec 1, 2020

Oh sorry, I confused this PR with my other one you reviewed haha. ^^

@timokau timokau changed the title undervolt: expose power limits as Nixopts [20.09] undervolt: expose power limits as Nixopts Dec 1, 2020
@timokau
Copy link
Member

timokau commented Dec 1, 2020

I reviewed this before I realized it was a backport and it looked good to me.

It is a convention (I'm not sure if its documented anywhere, but I do it and I have seen others do it too) to prefix backport PR titles with the release they are targeting. That helps to avoid that confusion.

timokau
timokau approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't see any reason against this backport, and our release managers are probably overworked. So let's just get this in :)

@timokau timokau merged commit 2fe8f33 into NixOS:release-20.09 Dec 1, 2020
@Atemu Atemu deleted the backport/undervolt-pl branch October 7, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyandresen bennyandresen bennyandresen approved these changes

@timokau timokau timokau approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Atemu @bennyandresen @timokau @FRidh