Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences Dialog: Warn user if they are about to discard changes #269

Closed
nshcat opened this issue Oct 31, 2020 · 1 comment
Closed

Preferences Dialog: Warn user if they are about to discard changes #269

nshcat opened this issue Oct 31, 2020 · 1 comment
Labels
ui New UI features
Milestone

Comments

@nshcat
Copy link
Collaborator

nshcat commented Oct 31, 2020

Currently, when the user clicks on "Cancel", the dialog will not warn them about any changes that would be lost.

The message box could also list the settings that have been changed, since we have that information.

Maybe something like this:

"The following changes are about to be discarded, are you sure?
Appearance > Waveforms > Color Cursor 1
Appearance > Waveforms > Color Cursor 2

yes/no"

@nshcat nshcat added the ui New UI features label Oct 31, 2020
@azonenberg azonenberg added this to the v0.1 milestone Apr 24, 2021
@azonenberg
Copy link
Collaborator

Closing because ngscopeclient now applies preference changes modelessly, so there's no concept of cancel/apply anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui New UI features
Projects
None yet
Development

No branches or pull requests

2 participants