Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doxygen: 1.8.19 -> 1.8.20 #102196

Merged
merged 1 commit into from Nov 7, 2020
Merged

doxygen: 1.8.19 -> 1.8.20 #102196

merged 1 commit into from Nov 7, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 30, 2020

Motivation for this change

Replace #100881

That was against master, plus I took the chance to make some more changes.

  1. move doxygen_gui to qt5
  2. modernize the expression a bit
  3. disable enableParallel, since it reproducably failed on my dual-socket Xeon machine
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NeQuissimus

@ajs124
doxygen: 1.8.19 -> 1.8.20
1f75b60 
also move doxygen_gui to qt5 and modernize the expression a bit

enableParallel was disabled, since it reproducably failed on my
dual-socket Xeon machine
@vcunat vcunat merged commit 45009ca into NixOS:staging Nov 7, 2020
@vcunat vcunat mentioned this pull request Nov 7, 2020
Closed
10 tasks
@ajs124 ajs124 deleted the upd/doxygen branch November 7, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

@vcunat vcunat vcunat left review comments

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @ryantm @NeQuissimus @vcunat