Make gdk-pixbuf support avif #102189

mkg20001 · 2020-10-30T21:41:50Z

Motivation for this change

Staying up-to-date with technical progress

Things done

mkg20001 · 2020-10-30T21:43:31Z

Build fails as it tries to copy to ${GDK_PIXBUF_MODULEDIR} which is inside the pixbuf package

Which directory should it store the loader in?

mkg20001 · 2020-10-30T21:45:43Z

Also should libavif be propagated in any way so that it's automatically "just there"? Adding it to gdk-pixbuf causes infinite recursion, since that's a dep of libavif

SuperSandro2000 · 2020-10-30T21:54:33Z

Also should libavif be propagated in any way so that it's automatically "just there"? Adding it to gdk-pixbuf causes infinite recursion, since that's a dep of libavif

This should be detected automatically if a so is linked against it. If this does not happen add it to propagatedBuildInputs.

Build fails as it tries to copy to ${GDK_PIXBUF_MODULEDIR} which is inside the pixbuf package

You can replace that path with ${gdk-pixbuf}/some/path.

Which directory should it store the loader in?

It should be copied to $out. I am not sure where it lives under systems like Debian but /var/share should be $out/share.

mkg20001 · 2020-10-30T22:10:24Z

We're building libavif here, we can't write to gdk-pixbuf because that's already built

Or are you saying I'm supposed to build the loader in gdk-pixbuf?

SuperSandro2000 · 2020-10-30T23:43:35Z

We're building libavif here, we can't write to gdk-pixbuf because that's already built

Than I was misunderstanding you. Sorry.

Or are you saying I'm supposed to build the loader in gdk-pixbuf?

I am not sure. I am not very familiar with this library. A third option would be to add another package and build it there.

jtojnar · 2020-10-31T09:41:45Z

You can change the path using environment variable:

PKG_CONFIG_GDK_PIXBUF_2_0_GDK_PIXBUF_MODULEDIR = "${placeholder "out"}/${gdk-pixbuf.moduleDir}";

But loading will still be a problem, see the docs in https://github.com/NixOS/nixpkgs/pull/101537/files

mkg20001 · 2020-10-31T11:15:43Z

<package>gdk-pixbuf</package> setup hook will populate <envar>GDK_PIXBUF_MODULE_FILE</envar> with the path to biggest <filename>loaders.cache</filename> file from the dependencies containing <link xlink:href="ssec-gnome-gdk-pixbuf-loaders">GdkPixbuf loaders</link>.

WHAT THE FUCK? That's like counting corona cases based on the weight of the paper.

Isn't there some method to merge all the loader caches?

jtojnar · 2020-10-31T11:21:34Z

Sure, the docs mention the module

nixpkgs/nixos/modules/services/x11/gdk-pixbuf.nix

Lines 11 to 25 in 1ecc5c7

    
             # Generate the cache file by running gdk-pixbuf-query-loaders for each 
        
             # package and concatenating the results. 
        
             loadersCache = pkgs.runCommand "gdk-pixbuf-loaders.cache" { preferLocalBuild = true; } '' 
        
               ( 
        
                 for package in ${concatStringsSep " " effectivePackages}; do 
        
                   module_dir="$package/${pkgs.gdk-pixbuf.moduleDir}" 
        
                   if [[ ! -d $module_dir ]]; then 
        
                     echo "Warning (services.xserver.gdk-pixbuf): missing module directory $module_dir" 1>&2 
        
                     continue 
        
                   fi 
        
                   GDK_PIXBUF_MODULEDIR="$module_dir" \ 
        
                     ${pkgs.stdenv.hostPlatform.emulator pkgs.buildPackages} ${pkgs.gdk-pixbuf.dev}/bin/gdk-pixbuf-query-loaders 
        
                 done 
        
               ) > "$out" 
        
             '';

, we would need to make wrapGAppsHook do that and include the cache file in each derivation using wrapGAppsHook.

mkg20001 · 2020-11-02T12:46:01Z

Setting services.xserver.gdk-pixbuf.modulePackages = with pkgs; [ libavif ]; should be enough to get it working, right?

What is the cache then used for in the package itself?

Why should we have both? (cache in package and generated cache per nixOS options)

jtojnar · 2020-11-02T13:30:34Z

Setting services.xserver.gdk-pixbuf.modulePackages = with pkgs; [ libavif ]; should be enough to get it working, right?

No, packages using wrapGAppsHook will override the environment variable so they will not see it.

What is the cache then used for in the package itself?

The environment variable is set in the wrapper to make it more hermetic. Images would not work otherwise on systems that do not set the environment variable globally.

Why should we have both? (cache in package and generated cache per nixOS options)

I do not think we should have the NixOS option but some people disagree. Edit: #42562

mkg20001 · 2020-11-02T13:39:28Z

I see gdk-pixbuf modules from the prespective of a nixOS user installing avif support (for ex) globally, so that the file-manager can render thumbnails.

Having it per package makes it weird for the edge case that there's multiple cache files in the system.

Setting the loaders cache by default with wrapGAppsHook doesn't make too much sense if no extra loaders are included, assuming default ones always loaded.

It could be changed so that only packages that have a hard-requirement on specific loaders have their own cache shipped that doesn't interfere with the global configuration.

jtojnar · 2020-11-02T13:45:07Z

I see gdk-pixbuf modules from the prespective of a nixOS user installing avif support (for ex) globally, so that the file-manager can render thumbnails.

Yeah, this is hard.

Having it per package makes it weird for the edge case that there's multiple cache files in the system.

🤷‍♀️

Setting the loaders cache by default with wrapGAppsHook doesn't make too much sense if no extra loaders are included, assuming default ones always loaded.

We are loading the librsvg wrapper, which all GTK apps need to render window close button and other icons.

It could be changed so that only packages that have a hard-requirement on specific loaders have their own cache shipped that doesn't interfere with the global configuration.

🤷‍♀️

Also with global flag you get delightful bugs like #54278 and #60254.

pkgs/development/libraries/libavif/default.nix

jtojnar · 2020-11-02T14:53:12Z

pkgs/development/libraries/libavif/thumbnailer

@@ -0,0 +1,5 @@
+[Thumbnailer Entry]
+TryExec=@bindir@/gdk-pixbuf-thumbnailer
+Exec=@bindir@/gdk-pixbuf-thumbnailer -s %s %u %o


As discussed on IRC, you will need to generate a loaders.cache file and pass it to the program through environment.

jtojnar · 2020-11-02T14:53:53Z

pkgs/development/libraries/libavif/default.nix

@@ -22,11 +23,14 @@ stdenv.mkDerivation rec {

  # reco: encode libaom slowest but best, decode dav1d fastest

+  PKG_CONFIG_GDK_PIXBUF_2_0_GDK_PIXBUF_MODULEDIR = "${placeholder "gdkPixbufLoader"}/${gdk-pixbuf.moduleDir}";


Environment variables typically go down, but this expression is already a bit lopsided.

Co-authored-by: Jan Tojnar <jtojnar@gmail.com>

SuperSandro2000 · 2021-01-18T17:35:45Z

@mkg20001 ping

stale · 2021-07-21T02:11:57Z

I marked this as stale due to inactivity. → More info

nixos-discourse · 2021-11-19T14:46:53Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/webp-support-in-nautilus-and-eog-eye-of-gnome/16158/4

ncfavier · 2023-07-21T21:09:18Z

I've resurrected this in #244723

mkg20001 mentioned this pull request Oct 30, 2020

Add gdk-pixbuf support to libavif #102063

Open

mkg20001 force-pushed the avifgdk branch from b2fd6e0 to 648fb9a Compare October 30, 2020 21:44

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 30, 2020

mkg20001 force-pushed the avifgdk branch from 648fb9a to 31653b6 Compare November 2, 2020 13:32

jtojnar reviewed Nov 2, 2020

View reviewed changes

mkg20001 added 2 commits November 9, 2020 21:53

libavif: build gdk-pixbuf module

8e01f79

libavif: add thumbnailer

74dedc3

mkg20001 force-pushed the avifgdk branch from 63809cc to 6b8e24a Compare November 9, 2020 20:54

libavif: move pixbuf loader to .gdkPixbufLoader

1cb61c6

Co-authored-by: Jan Tojnar <jtojnar@gmail.com>

mkg20001 force-pushed the avifgdk branch from 6b8e24a to 1cb61c6 Compare November 9, 2020 20:55

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 19, 2021

cwyc mentioned this pull request Jan 2, 2022

gdk-pixbuf: multiple module files #153275

Draft

13 tasks

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022

jtojnar mentioned this pull request Oct 21, 2022

eog: add libjxl for jpegxl support #197005

Closed

ncfavier mentioned this pull request Jul 21, 2023

libavif: build gdk-pixbuf loader and thumbnailer #244723

Merged

12 tasks

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2023

SuperSandro2000 closed this Jul 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make gdk-pixbuf support avif #102189

Make gdk-pixbuf support avif #102189

mkg20001 commented Oct 30, 2020

mkg20001 commented Oct 30, 2020

mkg20001 commented Oct 30, 2020

SuperSandro2000 commented Oct 30, 2020

mkg20001 commented Oct 30, 2020

SuperSandro2000 commented Oct 30, 2020

jtojnar commented Oct 31, 2020

mkg20001 commented Oct 31, 2020

jtojnar commented Oct 31, 2020

mkg20001 commented Nov 2, 2020

jtojnar commented Nov 2, 2020 •

edited

mkg20001 commented Nov 2, 2020

jtojnar commented Nov 2, 2020

jtojnar Nov 2, 2020

jtojnar Nov 2, 2020

SuperSandro2000 commented Jan 18, 2021

stale bot commented Jul 21, 2021

nixos-discourse commented Nov 19, 2021

ncfavier commented Jul 21, 2023

		@@ -22,11 +23,14 @@ stdenv.mkDerivation rec {

		# reco: encode libaom slowest but best, decode dav1d fastest

		PKG_CONFIG_GDK_PIXBUF_2_0_GDK_PIXBUF_MODULEDIR = "${placeholder "gdkPixbufLoader"}/${gdk-pixbuf.moduleDir}";

Make gdk-pixbuf support avif #102189

Make gdk-pixbuf support avif #102189

Conversation

mkg20001 commented Oct 30, 2020

Motivation for this change

Things done

mkg20001 commented Oct 30, 2020

mkg20001 commented Oct 30, 2020

SuperSandro2000 commented Oct 30, 2020

mkg20001 commented Oct 30, 2020

SuperSandro2000 commented Oct 30, 2020

jtojnar commented Oct 31, 2020

mkg20001 commented Oct 31, 2020

jtojnar commented Oct 31, 2020

mkg20001 commented Nov 2, 2020

jtojnar commented Nov 2, 2020 • edited

mkg20001 commented Nov 2, 2020

jtojnar commented Nov 2, 2020

jtojnar Nov 2, 2020

Choose a reason for hiding this comment

jtojnar Nov 2, 2020

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 18, 2021

stale bot commented Jul 21, 2021

nixos-discourse commented Nov 19, 2021

ncfavier commented Jul 21, 2023

jtojnar commented Nov 2, 2020 •

edited