Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] linux: add flavor metadata #102208

Merged
merged 1 commit into from Oct 31, 2020
Merged

[20.09] linux: add flavor metadata #102208

merged 1 commit into from Oct 31, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 31, 2020 •
edited

Motivation for this change

backport #102005
related #101863

(cherry picked from commit e6db435)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
linux: add flavor metadata
12ac3ad 
(cherry picked from commit e6db435)
@jonringer jonringer changed the title linux: add flavor metadata [20.09] linux: add flavor metadata Oct 31, 2020
@jonringer
Copy link
Contributor Author 

Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/102208
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-102208/shell.nix

@jonringer
Copy link
Contributor Author

ran ofborg locally

[22:06:39] jon@nixos ~/projects/nixpkgs (backport-linux-flavor)
$ GC_INITIAL_HEAP_SIZE=16g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > out-paths
[22:09:27] jon@nixos ~/projects/nixpkgs (backport-linux-flavor)

@jonringer jonringer merged commit cb1c8da into NixOS:release-20.09 Oct 31, 2020
@jonringer jonringer deleted the backport-linux-flavor branch October 31, 2020 05:10
@dasJ
Copy link
Member

dasJ commented Nov 1, 2020

Huh? I thought backports were for fixes? This introduces a new feature…

@jonringer
Copy link
Contributor Author

I still needed to mark the related modules as broken, but didn't like that we didn't have good primitives around specifying kernel version ranges, or "variants".

work was done in #102209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @dasJ