Support journal gatewayd #102213
Closed
Support journal gatewayd #102213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae896e0. Systemd compilation now succeeds with our libmicrohttpd version.
|
@GrahamcOfBorg test systemd |
|
This should probably be optional, since we're going that way with #101886. Assuming that gets merged, but I don't see why it wouldn't. |
nlewo
requested review from
cdepillabout,
Ericson2314,
FRidh,
infinisil,
jonringer,
Lassulus,
mmahut,
nbp,
Profpatsch,
stigtsp,
thoughtpolice and
ttuegel
as code owners
|
Hm, it's actually hard to apply the revert on staging because of merge conflicts. So, I don't think it's relevant to keep this PR open. |
ofborg
bot
added
6.topic: qt/kde
6.topic: stdenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since ae896e0, Systemd is no longer compiled with the http gateway because of an incompatibility between Systemd and libmicrohttpd. However, because of some updates, it is now building fine!
I also enable this feature is the systemd test to ensure the option
services.journald.enableHttpGatewayis working as excepted.Note i also want to backport this patch to 20.09.
cc @flokli
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)