Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/transmission: point at the settings dir in cfg.home. #102204

Merged
merged 1 commit into from Nov 2, 2020
Merged

nixos/transmission: point at the settings dir in cfg.home. #102204

merged 1 commit into from Nov 2, 2020

Conversation

danderson
Copy link
Contributor

Without this, transmission starts with an empty config when using
a custom home location.

Signed-off-by: David Anderson dave@natulte.net

Motivation for this change

Transmission doesn't start with the right config on 20.09 because of this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danderson
nixos/transmission: point at the settings dir in cfg.home.
43effbb 
Without this, transmission starts with an empty config when using
a custom home location.

Signed-off-by: David Anderson <dave@natulte.net>
@infinisil infinisil merged commit aeaf78a into NixOS:master Nov 2, 2020
@infinisil
Copy link
Member

Backported to 20.09 in db36689

@danderson danderson deleted the danderson/transmission-dir branch November 2, 2020 23:53
@danderson danderson restored the danderson/transmission-dir branch November 4, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danderson @infinisil