New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] python-miio: fix #102210
[20.09] python-miio: fix #102210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.
Namely, you should be doing git cherry-pick -x <rev>
from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build
821edf2
to
a71d268
Compare
Oh, I see. Sorry for missing that. Fixed now. |
Result of 2 packages marked as broken and skipped:
|
Result of 2 packages marked as broken and skipped:
|
please rebase on the latest
|
(cherry picked from commit 79e81e8)
a71d268
to
251adcf
Compare
I've rebased and added a commit that removes the 'broken = true'. Is is okay to add the commit here or should I have that merged to master and then include it here? |
Since this doesn't reflect master, yes, it's perfectly find to add another commit. I had it in my initial review as well (it was the last line)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/NixOS/nixpkgs/pull/102210
2 packages built:
python37Packages.python-miio python38Packages.python-miio
Backport of #102183.
Motivation for this change
Fix the python-miio package for the 20.09 relase as well.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)