Revert "Reenable scroll-animations/element-based-offset tests" #26162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 19, 2020
This reverts commit bc2f9ba029056f669cfd0a71fe4b2bad6b58b494. Reason for revert: The test is still flaky. Original change's description: > Reenable scroll-animations/element-based-offset tests > > The underlying source of the test flakes was likely addressed in > recent changes to the handling of play and pause for scroll-linked > animations. > > https://chromium-review.googlesource.com/c/chromium/src/+/2386339 > > This patch also contains a cleanup to remove the unnecessarily > convoluted way of hiding the scrollbar for the clamped offset test. > > Tested with 1000+ retries of the two tests in a virtual threaded > environment. > > Bug: 1080609 > Change-Id: If9097b0a2017a9c87a359b61ba93f35bae56b512 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475935 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817568} TBR=kevers@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1080609 Change-Id: Ic31eede5561182d78e7bf805cd1f112edfd5379c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483585 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818355}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2483585
branch
from
7a83259
to
82d9ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bc2f9ba029056f669cfd0a71fe4b2bad6b58b494.
Reason for revert: The test is still flaky.
Original change's description:
TBR=kevers@chromium.org,xidachen@chromium.org
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1080609
Change-Id: Ic31eede5561182d78e7bf805cd1f112edfd5379c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483585
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818355}