Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwin: apply @tildearrow's low latency patch #101041

Closed
wants to merge 1 commit into from
Closed

kwin: apply @tildearrow's low latency patch #101041

wants to merge 1 commit into from

Conversation

pasqui23
Copy link
Contributor

Motivation for this change

Adapting my previous work in #89234 to Plasma 5.18
Fixes #85541

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/340

SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
pkgs/desktops/plasma-5/kwin/default.nix
plasma-framework, libcap, libdrm, mesa
plasma-framework, libcap, libdrm, mesa,

lowLatencyPatch ? true, fetchpatch ? null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lowLatencyPatch ? true, fetchpatch ? null
lowLatencyPatch ? true, fetchpatch

Should we enable this on default? I am not sure. @ttuegel do you have an opinion about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think we should not add patches by default that aren't fixing some bug. But, we can add a top-level attribute for it, so it will be built with and without the patch on Hydra.

pkgs/desktops/plasma-5/kwin/default.nix
@@ -37,7 +39,13 @@ mkDerivation {
patches = [
./0001-follow-symlinks.patch
./0002-xwayland.patch
];
]++ lib.optional lowLatencyPatch (fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]++ lib.optional lowLatencyPatch (fetchpatch {
] ++ lib.optional lowLatencyPatch (fetchpatch {

@ttuegel
Copy link
Member

ttuegel commented Nov 28, 2020

Besides my other comment, please add a NixOS option to override the kwin package chosen by the Plasma module.

@InternetUnexplorer
Copy link
Contributor

InternetUnexplorer commented Jan 4, 2021 •
edited

Besides my other comment, please add a NixOS option to override the kwin package chosen by the Plasma module.

@ttuegel I'm not the author, but I might give it a go (if the author doesn't mind, of course) since this PR seems to have stalled and I'm interested in learning more about NixOS. However, I'm having trouble figuring out the specifics (mostly naming).

I looked around a bit and services.xserver.desktopManager.plasma5 seems like it might be a good place to put it, but I'm not sure what the option name should be. Some ideas are:

  • kwinPackage
  • kwin.package
  • kwin

In general I'm not super familiar with NixOS yet, and so while I've looked a bit at other modules I still don't have a good sense of what would be most consistent/predictable.

Also, would desktops/plasma-5/3rdparty/kwin be a good place to put the kwin-lowlatency package?

@InternetUnexplorer InternetUnexplorer mentioned this pull request Jan 10, 2021
Closed
10 tasks
@InternetUnexplorer
Copy link
Contributor

I'm wondering if this and #85541 should be closed, as it was mentioned in #108987 that an overlay is probably the best way to go.

For everyone here who was interested, I've set up an overlay and binary cache here which I plan on keeping up-to-date for the foreseeable future.

@pasqui23
Copy link
Contributor Author

@InternetUnexplorer is right, this is better as an overlay

@pasqui23 pasqui23 closed this Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add package for kwin-lowlatency
5 participants
@pasqui23 @nixos-discourse @ttuegel @InternetUnexplorer @SuperSandro2000