Skip to content

Commit db9eee2

Browse files
authoredOct 18, 2020
Contributing doc: Minor improvements and a clarification (#10520)
1 parent 738f624 commit db9eee2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed
 

‎.github/CONTRIBUTING.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,9 @@ Contributions are welcome! Here's how you can help:
4545

4646
### Important note about automated GitHub checks
4747

48-
When you submit a pull request, GitHub automatically runs checks on the Minetest Engine combined with your changes. One of these checks is called 'cpp lint / clang format', which checks code formatting.
49-
Because formatting for readability requires human judgement this check often fails and often makes unsuitable formatting requests which make code readability worse.
48+
When you submit a pull request, GitHub automatically runs checks on the Minetest Engine combined with your changes. One of these checks is called 'cpp lint / clang format', which checks code formatting. Because formatting for readability requires human judgement this check often fails and often makes unsuitable formatting requests which make code readability worse.
5049

51-
If this check fails, look at the details to check for any clear mistakes and correct those. However you should not apply everything ClangFormat requests, ignore requests that make code readability worse and any other clearly unsuitable requests.
52-
Discuss with a core developer if in any doubt and for how to progress.
50+
If this check fails, look at the details to check for any clear mistakes and correct those. However, you should not apply everything ClangFormat requests. Ignore requests that make code readability worse and any other clearly unsuitable requests. Discuss in the pull request with a core developer about how to progress.
5351

5452
## Issues
5553

0 commit comments

Comments
 (0)
Please sign in to comment.