Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.pyhaversion: add missing semantic-version #101047

Merged
merged 1 commit into from Oct 19, 2020
Merged

[20.09] python3Packages.pyhaversion: add missing semantic-version #101047

merged 1 commit into from Oct 19, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 19, 2020 •
edited

(cherry picked from commit 92bf2d7)

Motivation for this change

ZHF: #97479
backport of #97578

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip -b release-20.09"
  • Tested execution of all binary files (usually in ./result/bin/)
    • (there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

    • ❌ meta.license is not set

    • 🤔 a verb seems to be missing in meta.description:

      A python module to the newest version number of Home Assistant

      although that matches the upstream README, it should maybe be

      A python module to determine the newest version number of Home Assistant

      or similar?

@das-g
Copy link
Member Author

das-g commented Oct 19, 2020

Result of nixpkgs-review pr 101047 1

2 packages built:
  • python37Packages.pyhaversion
  • python38Packages.pyhaversion

@ofborg ofborg bot requested a review from makefu October 19, 2020 02:24
jonringer
jonringer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101047 1

2 packages built:
  • python37Packages.pyhaversion
  • python38Packages.pyhaversion

@jonringer jonringer merged commit b555b3a into NixOS:release-20.09 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @jonringer @makefu