python: pyxdg: 0.26 -> 0.27 #101045
Merged
python: pyxdg: 0.26 -> 0.27 #101045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjlbach
force-pushed
the
feature/bump_pyxdg
branch
from
3a7cf3d
to
2d549ed
Compare
mweinelt
requested changes
Oct 19, 2020
mjlbach
force-pushed
the
feature/bump_pyxdg
branch
3 times, most recently
from
4bb0ca6
to
ed41643
Compare
| sha256 = "17cjax546rkqv5kvwczjqjdd6vmlvcxjanz0296dlfq23j2wbx63"; | ||
| }) | ||
| ]; | ||
| #Currently these tests fail (4 errors, 4 warnings) |
There was a problem hiding this comment.
Please remove the commented out code.
There was a problem hiding this comment.
Done, the tests are still failing and I've removed references to the tests.
mjlbach
force-pushed
the
feature/bump_pyxdg
branch
3 times, most recently
from
acbe2c4
to
c64c780
Compare
mjlbach
force-pushed
the
feature/bump_pyxdg
branch
from
c64c780
to
40389df
Compare
|
@SuperSandro2000 @mweinelt Unless we want to try to figure out why the tests are failing, I think this is ready to merge. |
|
Result of 11 packages marked as broken and skipped:
6 packages failed to build:
12 packages built:
Going to fix those build failures in another PR. |
10 tasks
|
Result of 17 packages failed to build:
50 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bump pyxdg and remove need for external patch (upstreamed),
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)