Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfan: fix build failures with cddlib v0.94l #101046

Merged
merged 1 commit into from Oct 19, 2020
Merged

gfan: fix build failures with cddlib v0.94l #101046

merged 1 commit into from Oct 19, 2020

Conversation

omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 19, 2020 •
edited

Motivation for this change

This change fixes #100622.

Some of the tests in sage-tests fail on my machine, though it is still an improvement toward making Sage latest and working.

2 packages failed to build:
sage sageWithDoc

1 package built:
gfan

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori
gfan: fix build failures with cddlib v0.94l
096ef94 
It fixes NixOS#100622.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@ofborg ofborg bot requested a review from 7c6f434c October 19, 2020 01:41
@7c6f434c 7c6f434c merged commit d4328e9 into NixOS:master Oct 19, 2020
@omasanori omasanori deleted the gfan-unbreak branch October 19, 2020 09:13
@omasanori omasanori mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gfan: fails to build: setoper.h: No such file or directory
2 participants
@omasanori @7c6f434c