imgbrd-grabber: init at 7.3.2 #101048
Merged
imgbrd-grabber: init at 7.3.2 #101048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think I figured out what was wrong with the source builds. |
|
Changes have been pushed. |
|
@jonringer Any thoughts on the transition from binary -> source builds here? Sort of paranoid on whether I'm missing anything else, or if the |
|
Result of 1 package built:
did a quick test and it seems to work as well as it did on arch |
|
Result of 1 package built:
|
|
just noticed that you forgot to add the meta section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
imgbrd-grabber: "Very customizable imageboard/booru downloader with powerful filenaming features."
Closes #67632
Can be sourced by Hydrus once #101034 is merged.
Things Done
I only considered the Linux application but I doubt it would be much work to get things working on macOS.
Notes
I initially tried to build from source, but the build usesnpm installfor sites module.Additionally, thepackage.jsondoes not contain aversion(required for node2nix), so I settled on packaging the binary application for now.Update:
I have pushed an expression that builds the application from source.
Bugs
With
7.3.2,Grabber-clicrashes when used.This is solved by Bionus/imgbrd-grabber@3814631.
This has not yet been merged, and the patch does not apply cleanly on top of
7.3.2.For more information, see the issue.
cc @klorophatu @toyo-chi @hyarsan @deliciouslytyped