Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: support disabling building shared lib #101055

Merged
merged 1 commit into from Oct 19, 2020
Merged

rocksdb: support disabling building shared lib #101055

merged 1 commit into from Oct 19, 2020

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Oct 19, 2020 •
edited

Motivation for this change

This is needed to build pkgsStatic.rocksdb.

(cherry picked from #100975 commit c6109ef)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
rocksdb: support disabling building shared lib
d56b86a 
This is needed to build `pkgsStatic.rocksdb`.

(cherry picked from commit c6109ef)
@basvandijk
Copy link
Member Author

@GrahamcOfBorg build rocksdb

@basvandijk basvandijk merged commit ba2ec48 into NixOS:release-20.09 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@basvandijk