Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[layout] Fix OOF replaced elements with display: table. #26161

Merged
merged 1 commit into from Oct 19, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 19, 2020

Previously we had special logic within ng_absolute_utils.cc which simply
checked if we had an element with display:table for some table specific
logic.

This was incorrect, and should have been checking for the LayoutObject
type instead.
This caused some incorrect layout of replaced elements when OOF.

This patch uses the NGBlockNode::IsTable instead to apply this logic.

Bug: 1138851
Change-Id: Id428df4f48c48ad949bd3d8ffce70827e8809081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483962
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818448}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Previously we had special logic within ng_absolute_utils.cc which simply
checked if we had an element with display:table for some table specific
logic.

This was incorrect, and should have been checking for the LayoutObject
type instead.
This caused some incorrect layout of replaced elements when OOF.

This patch uses the NGBlockNode::IsTable instead to apply this logic.

Bug: 1138851
Change-Id: Id428df4f48c48ad949bd3d8ffce70827e8809081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483962
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818448}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants