Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdenlive: fix package #102364

Merged
merged 3 commits into from Nov 1, 2020
Merged

kdenlive: fix package #102364

merged 3 commits into from Nov 1, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 1, 2020

Motivation for this change

Build and runs fine.

Note you may get an issue running this if your GL build is different.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from ttuegel as a code owner November 1, 2020 16:56
@FRidh FRidh changed the title kdenlive: fix build kdenlive: fix package Nov 1, 2020
Copy link
Contributor

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, it works.

@FRidh FRidh merged commit c3d017e into NixOS:master Nov 1, 2020
@FRidh FRidh deleted the kdenlive branch November 1, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants