Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.google_cloud_pubsub: disable tests #102403

Merged
merged 1 commit into from Nov 2, 2020
Merged

python3Packages.google_cloud_pubsub: disable tests #102403

merged 1 commit into from Nov 2, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2020 •
edited

Motivation for this change

noticed https://hydra.nixos.org/build/127651506 and https://hydra.nixos.org/build/127623871 were queued for a long time.

tests fail to clean up nicely.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
python3Packages.google_cloud_pubsub: disable tests
9d5b01e 
tests fail due to file handle issues, then just loops
in an invalid state until timing out on hydra

https://hydra.nixos.org/build/129081889
@jonringer jonringer requested a review from FRidh as a code owner November 1, 2020 23:16
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2020
@bhipple
Copy link
Contributor

bhipple commented Nov 2, 2020

Result of nixpkgs-review pr 102403 1

2 packages built:
- python37Packages.google_cloud_pubsub
- python38Packages.google_cloud_pubsub

@bhipple bhipple merged commit 6a563e1 into NixOS:master Nov 2, 2020
@jonringer jonringer deleted the pubsub branch November 2, 2020 00:33
@jonringer jonringer mentioned this pull request Nov 2, 2020
Merged
10 tasks
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@costrouc costrouc Awaiting requested review from costrouc

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @bhipple @erictapen