Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.plaid-python: 6.0.0 -> 7.1.0 #102368

Merged
merged 1 commit into from Nov 25, 2020
Merged

pythonPackages.plaid-python: 6.0.0 -> 7.1.0 #102368

merged 1 commit into from Nov 25, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Nov 1, 2020

There's been a new major version update of the server API, so the 6.X line no longer works.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
pythonPackages.plaid-python: 6.0.0 -> 7.1.0
175cf97 
There's been a new major version update of the server API, so the 6.X line no longer works.
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102368 run on x86_64-darwin 1

3 packages built:
  • python27Packages.plaid-python
  • python37Packages.plaid-python
  • python38Packages.plaid-python

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102368 run on x86_64-linux 1

3 packages built:
  • python27Packages.plaid-python
  • python37Packages.plaid-python
  • python38Packages.plaid-python

bhipple added a commit to bhipple/plaid2qif that referenced this pull request Nov 1, 2020
@bhipple
Fix Client constructor for use on plaid-python 7.1.0 and plaid API ve…
f4eaf61 
…rsion 2020-09-14

In the newer `plaid-python` library, the 3rd positional argument to the
`plaid.Client` constructor war removed [1], causing all of our other args to shift
and pass the token as the env, suppress warnings as the timeout, etc.

This updates the code to use kwargs instead, so that we don't depend on the
relative ordering in the class constructor. I've tested this successfully with
the versions listed in the subject line as part of packaging for NixPkgs [2]

With this commit, we can download new transactions with the latest libs and API,
which gives us most of the support for resolving ebridges#16 (just the docs/code on
creating new link tokens needs to be updated).

[1] https://github.com/plaid/plaid-python/blob/a0f7891dac304b6d8bee08ec4286fcaa8b5358f5/plaid/client.py#L39-L46
[2] NixOS/nixpkgs#102368
@bhipple bhipple mentioned this pull request Nov 1, 2020
Merged
@SuperSandro2000 SuperSandro2000 merged commit 26c12be into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @SuperSandro2000