Skip to content

extra-container: init at 0.8 #102354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

erikarvstedt
Copy link
Member

@erikarvstedt erikarvstedt commented Nov 1, 2020

extra-container is a tool for running declarative NixOS containers without host system rebuilds.

cc @Lassulus

Things done

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 1, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102354 run on x86_64-linux 1

1 package built:
  • extra-container

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@veehaitch
Copy link
Member

@erikarvstedt Thanks for this PR. Could you please resolve the conflict and update the PR to use the latest version?

@stale
Copy link

stale bot commented Sep 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 26, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 30, 2021
@Lassulus Lassulus changed the title extra-container: init at 0.5 extra-container: init at 0.7 Sep 30, 2021
@Lassulus
Copy link
Member

I have taken the liberty to fix the merge conflict and update to the newest version

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 30, 2021
@erikarvstedt
Copy link
Member Author

erikarvstedt commented Sep 30, 2021

I've released a new version that adds compatibility with nixpkgs unstable.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 30, 2021
@erikarvstedt erikarvstedt force-pushed the extra-container branch 2 times, most recently from c07c29e to d9b787e Compare September 30, 2021 19:11
@erikarvstedt
Copy link
Member Author

erikarvstedt commented Sep 30, 2021

Test the NixOS module with:

cfg="{
  containers.tmp.config = {
    programs.extra-container.enable = true;
    nix.nixPath = [ \"nixpkgs=$(realpath $(nix-instantiate --eval -E '<nixpkgs>'))\" ];
  };
}"
cfg2='{ containers.tmp = {}; }'
extra-container shell --nixpkgs-path /path/to/nixpkgs -E "$cfg" --run c extra-container shell -E "$cfg2" --run echo success

This builds a container with programs.extra-container enabled and runs extra-container within this container.

@erikarvstedt erikarvstedt changed the title extra-container: init at 0.7 extra-container: init at 0.8 Sep 30, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Lassulus Lassulus merged commit 1b94d11 into NixOS:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants