Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digikam: fix double wrapping #102351

Merged
merged 1 commit into from Nov 1, 2020
Merged

digikam: fix double wrapping #102351

merged 1 commit into from Nov 1, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 1, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102351 run on x86_64-linux 1

1 package failed to build:
  • digikam

@FRidh
Copy link
Member Author

FRidh commented Nov 1, 2020

@SuperSandro2000 flaky?

$ nix-build -A digikam
/nix/store/3j20bs9gvaapjvm054cn2l4ggbqviajs-digikam-7.1.0

@SuperSandro2000
Copy link
Member

@SuperSandro2000 flaky?

I think so. Currently debugging why. I think one of my builders has sometimes hikups which is not nice for reviews. I tried building it with nix-build and that worked.

@FRidh FRidh merged commit 9436457 into NixOS:master Nov 1, 2020
@FRidh FRidh deleted the digikam branch November 1, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @SuperSandro2000