Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyside,python3Packages.pysideTools,python3Packages.pysideShiboken,pysideApiExtractor,pysideGeneratorrunner: remove dependencies to python2 #102356

Merged
merged 5 commits into from Nov 1, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 1, 2020

Motivation for this change

Remove python2 dependencies, and refactor the pyside tools to use multiple outputs to reduce the size of the runtime dependencies

#101964

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Nov 1, 2020

Thank you. Note that pyside is old, it has not seen a release since 2015.

@FRidh FRidh merged commit 878bfaa into NixOS:master Nov 1, 2020
@jonringer
Copy link
Contributor

gah, fridh why do you always merge things before i do

https://github.com/NixOS/nixpkgs/pull/102356
8 packages built:
pysideApiextractor pysideGeneratorrunner python37Packages.pyside python37Packages.pysideShiboken python37Packages.pysideTools python38Packages.pyside python38Packages.pysideShiboken python38Packages.pysideTools

xD

@freezeboy
Copy link
Contributor Author

yes I saw it is old but I don't know if it is safe to remove, so at least I prefer to help phasing python2 away

@freezeboy freezeboy deleted the refactor-pyside-apiextractor branch November 1, 2020 16:14
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102356 run on x86_64-darwin 1

8 packages marked as broken and skipped:
  • pysideApiextractor
  • pysideGeneratorrunner
  • python37Packages.pyside
  • python37Packages.pysideShiboken
  • python37Packages.pysideTools
  • python38Packages.pyside
  • python38Packages.pysideShiboken
  • python38Packages.pysideTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants