Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/prometheus: remove invalid thanos config flag #102350

Merged
merged 1 commit into from Nov 1, 2020
Merged

nixos/tests/prometheus: remove invalid thanos config flag #102350

merged 1 commit into from Nov 1, 2020

Conversation

andir
Copy link
Member

@andir andir commented Nov 1, 2020 •
edited

Motivation for this change

Upstream has apparently changed the configuration format and is now
throwing an error when the encrypt_sse option is set. According to the
current version of the documentation encryption moved to the
sse_config option that (is optional and) offers all the features we do
not use or care about for this test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@andir
nixos/tests/prometheus: remove invalid thanos config flag
e486513 
Upstream has apparently changed the configuration format and is now
throwing an error when the `encrypt_sse` option is set. According to the
current version of the documentation encryption moved to the
`sse_config` option that (is optional and) offers all the features we do
not use or care about for this test.
@andir andir requested a review from WilliButz November 1, 2020 13:34
WilliButz
WilliButz approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus

@andir andir merged commit 2ba1c00 into NixOS:master Nov 1, 2020
@andir andir deleted the nixos-test-prometheus branch November 1, 2020 18:45
@mweinelt
Copy link
Member

mweinelt commented Nov 1, 2020

Fixes #102112 I assume?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @WilliButz @mweinelt