Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipreqs: use python3 #102389

Merged
merged 1 commit into from Nov 24, 2020
Merged

pipreqs: use python3 #102389

merged 1 commit into from Nov 24, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2020 •
edited

Motivation for this change

related: #101964

although this may lose support to parse python2 code, I think the compromise is worth it for not introducing vulnerabilities to a user's system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer mentioned this pull request Nov 1, 2020
Closed
77 tasks
@ofborg ofborg bot requested a review from PsyanticY November 1, 2020 21:12
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102389 run on x86_64-darwin 1

1 package built:
  • pipreqs

@jonringer
Copy link
Contributor Author

shows usage

going to merge to move foward with marking cryptography insecure

https://github.com/NixOS/nixpkgs/pull/102389
1 package built:
pipreqs

@jonringer jonringer closed this Nov 24, 2020
@jonringer jonringer reopened this Nov 24, 2020
@jonringer jonringer merged commit cc5a3cb into NixOS:master Nov 24, 2020
@jonringer jonringer deleted the pipreqs-py3 branch November 24, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @SuperSandro2000 @FRidh