Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove superflous format string when a variable can be used directly #102394

Closed
wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 1, 2020

Motivation for this change

Replaces

foo = "${bar}";

with

foo = bar;

when bar is of type string.

This very commonly used for rev = "${version}"; and repo = "${pname}";, where rev = version; and repo = pname; would be enough.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

when a string variable can be used directly
@jonringer
Copy link
Contributor

@prusnak
Copy link
Member Author

prusnak commented Nov 1, 2020

to no fault of your own: https://github.com/NixOS/nixpkgs/pull/102394/checks?check_run_id=1339322844

Not sure what this was about - I forced pushed and I can't seem to be able to read the logs of the older run

@prusnak
Copy link
Member Author

prusnak commented Nov 1, 2020

I am closing this and will follow up with more complex clean-up PR.

@prusnak prusnak closed this Nov 1, 2020
@prusnak prusnak deleted the superfluous-format-string branch November 1, 2020 21:28
@prusnak
Copy link
Member Author

prusnak commented Nov 1, 2020

Superseded by #102396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants