[20.09] rocksdb: 6.10.2 -> 6.12.7 #102401

basvandijk · 2020-11-01T22:47:38Z

Motivation for this change

https://github.com/facebook/rocksdb/blob/v6.12.7/HISTORY.md#6127-2020-10-14

Things done

Cherry-picked #101559 on release-20.09.

https://github.com/facebook/rocksdb/blob/v6.12.7/HISTORY.md#6127-2020-10-14 (cherry picked from commit f1c4d5d)

(cherry picked from commit f2ea8e4)

basvandijk · 2020-11-01T23:24:26Z

Result of nixpkgs-review pr 102401 1

1 package marked as broken and skipped:

bareos

10 packages built:

blockbook
ceph (ceph-dev)
ceph-client
haskellPackages.rocksdb-haskell
haskellPackages.rocksdb-haskell-jprupp
libceph
rocksdb
rocksdb_lite
sambaFull (samba4Full)
sortmerna

SuperSandro2000 · 2020-11-02T15:17:19Z

Result of nixpkgs-review pr 102401 run on x86_64-darwin 1

1 package marked as broken and skipped:

bareos

2 packages failed to build:

haskellPackages.rocksdb-haskell
sortmerna

2 packages built:

blockbook
haskellPackages.rocksdb-haskell-jprupp

haskellPackages.rocksdb-haskell

Preprocessing test suite 'rocksdb-tests' for rocksdb-haskell-1.0.1..
Building test suite 'rocksdb-tests' for rocksdb-haskell-1.0.1..
[1 of 1] Compiling Main             ( tests/tests.hs, dist/build/rocksdb-tests/rocksdb-tests-tmp/Main.o )
Linking dist/build/rocksdb-tests/rocksdb-tests ...
@nix { "action": "setPhase", "phase": "checkPhase" }
running tests
Running 1 test suites...
Test suite rocksdb-tests: RUNNING...

Basic DB Functionality
  should put items into the database and retrieve them
  should put items into a database whose filepath has unicode characters and retrieve them FAILED [1]

Failures:

  tests/tests.hs:37:5:
  1) Basic DB Functionality should put items into a database whose filepath has unicode characters and retrieve them
       uncaught exception: IOException of type InvalidArgument
       /private/tmp/nix-build-rocksdb-haskell-1.0.1.drv-0/rocksdb-8a3bc27558748166𳁂󽜧𨯂񊉺󸅡񆳒󃮱񛁖򻨄       򍮫񪱪򫨖: createDirectory: invalid argument (Illegal byte sequence)

  To rerun use: --match "/Basic DB Functionality/should put items into a database whose filepath has unicode characters and retrieve them/"

Randomized with seed 1422503008

Finished in 0.0119 seconds
2 examples, 1 failure
Test suite rocksdb-tests: FAIL
Test suite logged to: dist/test/rocksdb-haskell-1.0.1-rocksdb-tests.log
0 of 1 test suites (0 of 1 test cases) passed

sortmerna

BUILD 00:51:14 Sep 10 2020
configured to support archs: armv6 armv7 armv7s arm64 arm64e arm64_32 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em (tvOS)
Library search paths:
	/nix/store/nrsa1l0kh3vxindfkfa1d5fw62yvac4d-libc++-7.1.0/lib
	/nix/store/faz5fq60zphhc71falxxv3sj366xs9g4-libc++abi-7.1.0/lib
	/nix/store/hrk2rh0v2s0z1qbss60zcp807jnsbjfx-compiler-rt-7.1.0/lib
	/nix/store/74slwpsd5xdvy2g2kvzsyrrxhf58js8n-zlib-1.2.11/lib
	/nix/store/irrn9zadd6wlrmawp6bbywxfb5g662ac-rocksdb-6.12.7/lib
	/nix/store/ljpsnysvfv2mla436xhh3bm98xydfcwl-bzip2-1.0.6.0.1/lib
	/nix/store/23x7br4vfkxxf1ldbwsj1fwsjv7rsdqk-lz4-1.9.2/lib
	/nix/store/s3r5jpd5g58vhjlcpnjiv4hrnp34gdf9-snappy-1.1.8/lib
	/nix/store/1lwiq91jlnh72sdc4db34pbwxgi766yk-zstd-1.4.5/lib
	/nix/store/nrsa1l0kh3vxindfkfa1d5fw62yvac4d-libc++-7.1.0/lib
	/nix/store/faz5fq60zphhc71falxxv3sj366xs9g4-libc++abi-7.1.0/lib
	/nix/store/hrk2rh0v2s0z1qbss60zcp807jnsbjfx-compiler-rt-7.1.0/lib
	/nix/store/74slwpsd5xdvy2g2kvzsyrrxhf58js8n-zlib-1.2.11/lib
	/nix/store/irrn9zadd6wlrmawp6bbywxfb5g662ac-rocksdb-6.12.7/lib
	/nix/store/ljpsnysvfv2mla436xhh3bm98xydfcwl-bzip2-1.0.6.0.1/lib
	/nix/store/23x7br4vfkxxf1ldbwsj1fwsjv7rsdqk-lz4-1.9.2/lib
	/nix/store/s3r5jpd5g58vhjlcpnjiv4hrnp34gdf9-snappy-1.1.8/lib
	/nix/store/1lwiq91jlnh72sdc4db34pbwxgi766yk-zstd-1.4.5/lib
	/nix/store/h144jawqa92rqjhaahrsikq5j2dwkh5n-Libsystem-osx-10.12.6/lib
	/nix/store/xm9bgk78cyypmwpyfgns0qy2293cxy1k-clang-7.1.0-lib/lib
	/nix/store/nrsa1l0kh3vxindfkfa1d5fw62yvac4d-libc++-7.1.0/lib
Framework search paths:
	/nix/store/ws97llpijhnnvgxzj16kfqxmb0x3yhji-swift-corefoundation/Library/Frameworks
	/nix/store/ws97llpijhnnvgxzj16kfqxmb0x3yhji-swift-corefoundation/Library/Frameworks
Undefined symbols for architecture x86_64:
  "std::__1::__fs::filesystem::directory_iterator::__dereference() const", referenced from:
      Runopts::validate_kvdbdir() in options.cpp.o
  "std::__1::__fs::filesystem::path::__filename() const", referenced from:
      Index::Index(Runopts&) in index.cpp.o
      Runopts::opt_ref(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_reads(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_aligned(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_other(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::validate_idxdir() in options.cpp.o
      Runopts::validate_kvdbdir() in options.cpp.o
      ...
  "std::__1::__fs::filesystem::path::__parent_path() const", referenced from:
      Runopts::validate_aligned_pfx() in options.cpp.o
      Runopts::validate_other_pfx() in options.cpp.o
  "std::__1::__fs::filesystem::path::__root_directory() const", referenced from:
      Index::Index(Runopts&) in index.cpp.o
      Runopts::opt_ref(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_reads(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_aligned(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_other(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::validate_idxdir() in options.cpp.o
      Runopts::validate_kvdbdir() in options.cpp.o
      ...
  "std::__1::__fs::filesystem::__absolute(std::__1::__fs::filesystem::path const&, std::__1::error_code*)", referenced from:
      Index::Index(Runopts&) in index.cpp.o
      Runopts::opt_ref(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_workdir(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_kvdb(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_idx(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::validate_idxdir() in options.cpp.o
      Runopts::validate_kvdbdir() in options.cpp.o
      ...
  "std::__1::__fs::filesystem::__fs_is_empty(std::__1::__fs::filesystem::path const&, std::__1::error_code*)", referenced from:
      Index::Index(Runopts&) in index.cpp.o
      Runopts::validate_idxdir() in options.cpp.o
      Runopts::validate_kvdbdir() in options.cpp.o
  "std::__1::__fs::filesystem::__current_path(std::__1::error_code*)", referenced from:
      Runopts::opt_ref(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_reads(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
  "std::__1::__fs::filesystem::__create_directory(std::__1::__fs::filesystem::path const&, std::__1::error_code*)", referenced from:
      Runopts::validate_idxdir() in options.cpp.o
  "std::__1::__fs::filesystem::directory_iterator::__increment(std::__1::error_code*)", referenced from:
      Runopts::validate_kvdbdir() in options.cpp.o
  "std::__1::__fs::filesystem::directory_iterator::directory_iterator(std::__1::__fs::filesystem::path const&, std::__1::error_code*, std::__1::__fs::filesystem::directory_options)", referenced from:
      Runopts::validate_kvdbdir() in options.cpp.o
  "std::__1::__fs::filesystem::__create_directories(std::__1::__fs::filesystem::path const&, std::__1::error_code*)", referenced from:
      Runopts::validate_kvdbdir() in options.cpp.o
      Runopts::validate_aligned_pfx() in options.cpp.o
      Runopts::validate_other_pfx() in options.cpp.o
  "std::__1::__fs::filesystem::__status(std::__1::__fs::filesystem::path const&, std::__1::error_code*)", referenced from:
      Index::Index(Runopts&) in index.cpp.o
      Runopts::opt_ref(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::opt_reads(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in options.cpp.o
      Runopts::validate_idxdir() in options.cpp.o
      Runopts::validate_kvdbdir() in options.cpp.o
      Runopts::validate_aligned_pfx() in options.cpp.o
      Runopts::validate_other_pfx() in options.cpp.o
      ...
ld: symbol(s) not found for architecture x86_64
clang-7: �[0;1;31merror: �[0mlinker command failed with exit code 1 (use -v to see invocation)�[0m
make[2]: *** [src/sortmerna/CMakeFiles/sortmerna.dir/build.make:207: src/sortmerna/sortmerna] Error 1
make[1]: *** [CMakeFiles/Makefile2:242: src/sortmerna/CMakeFiles/sortmerna.dir/all] Error 2
make: *** [Makefile:171: all] Error 2

jonringer · 2020-11-06T23:12:54Z

is

Public API Change

    Reworked BackupableDBOptions::share_files_with_checksum_naming (new in 6.12) with some minor improvements and to better support those who were extracting files sizes from backup file names.

a backwards compatible change?

stale · 2021-06-04T08:55:41Z

I marked this as stale due to inactivity. → More info

mweinelt · 2021-07-05T20:09:19Z

Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one
month after the release of NixOS 21.05.

Since we do not accept any changes to its branches anymore, I'm closing this pull
request.

basvandijk and others added 2 commits November 1, 2020 23:42

rocksdb: 6.10.2 -> 6.12.7

74baa0c

https://github.com/facebook/rocksdb/blob/v6.12.7/HISTORY.md#6127-2020-10-14 (cherry picked from commit f1c4d5d)

rocksdb: propagate deps to fix build of sortmerna

5b191cd

(cherry picked from commit f2ea8e4)

ofborg bot requested review from magenbluten and adevress November 1, 2020 23:08

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Nov 1, 2020

basvandijk marked this pull request as ready for review November 1, 2020 23:24

jonringer changed the title ~~rocksdb: 6.10.2 -> 6.12.7 (cherry-pick on release-20.09)~~ [20.09] rocksdb: 6.10.2 -> 6.12.7 Nov 6, 2020

FRidh added the 12.release: stable label Nov 21, 2020

stale bot added the 2.status: stale label Jun 4, 2021

mweinelt closed this Jul 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20.09] rocksdb: 6.10.2 -> 6.12.7 #102401

[20.09] rocksdb: 6.10.2 -> 6.12.7 #102401

basvandijk commented Nov 1, 2020 •

edited

Loading

basvandijk commented Nov 1, 2020

SuperSandro2000 commented Nov 2, 2020 •

edited

Loading

jonringer commented Nov 6, 2020

stale bot commented Jun 4, 2021

mweinelt commented Jul 5, 2021

[20.09] rocksdb: 6.10.2 -> 6.12.7 #102401

[20.09] rocksdb: 6.10.2 -> 6.12.7 #102401

Conversation

basvandijk commented Nov 1, 2020 • edited Loading

Motivation for this change

Things done

basvandijk commented Nov 1, 2020

SuperSandro2000 commented Nov 2, 2020 • edited Loading

jonringer commented Nov 6, 2020

stale bot commented Jun 4, 2021

mweinelt commented Jul 5, 2021

basvandijk commented Nov 1, 2020 •

edited

Loading

SuperSandro2000 commented Nov 2, 2020 •

edited

Loading