Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault: 1.5.4 -> 1.5.5 #102402

Merged
merged 4 commits into from Nov 2, 2020
Merged

vault: 1.5.4 -> 1.5.5 #102402

merged 4 commits into from Nov 2, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102402 run on x86_64-darwin 1

2 packages built:
  • vault
  • vault-bin

Copy link
Contributor

@mkaito mkaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good to me. ofborg has been building this for 16 hours? Is that normal?

@marsam
Copy link
Contributor Author

marsam commented Nov 2, 2020

ofborg has been building this for 16 hours? Is that normal?

it's because currently there are no builders for darwin https://monitoring.nix.ci/dashboard/db/ofborg

@SuperSandro2000
Copy link
Member

it's because currently there are no builders for darwin monitoring.nix.ci/dashboard/db/ofborg

Can't we run the tests manually? I don't know the command.

@mkaito
Copy link
Contributor

mkaito commented Nov 2, 2020

That would be nix-build -A nixosTests.vault.

I just ran them, and they pass on my machine (x86_64-linux).

@ofborg ofborg bot requested a review from mkaito November 2, 2020 19:42
@marsam marsam merged commit 0da76da into NixOS:master Nov 2, 2020
@marsam marsam deleted the update-vault branch November 2, 2020 20:54
@SuperSandro2000
Copy link
Member

nix-build -A nixosTests.vault
error: assertion (stdenv).isLinux failed at /Users/user/nixpkgs2/pkgs/os-specific/linux/kernel/generic.nix:66:1
(use '--show-trace' to show detailed location information)

Does not run on darwin.

1 similar comment
@SuperSandro2000
Copy link
Member

nix-build -A nixosTests.vault
error: assertion (stdenv).isLinux failed at /Users/user/nixpkgs2/pkgs/os-specific/linux/kernel/generic.nix:66:1
(use '--show-trace' to show detailed location information)

Does not run on darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants