Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indilib: 1.1.0 -> 1.8.6 #102385

Merged
merged 2 commits into from Nov 9, 2020
Merged

indilib: 1.1.0 -> 1.8.6 #102385

merged 2 commits into from Nov 9, 2020

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Nov 1, 2020 •
edited

Motivation for this change

Receive upstream bugfixes and new astronomical equipment support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 2, 2020 •
edited

Result of nixpkgs-review pr 102385 run on x86_64-linux 1

1 package failed to build:
  • kstars
1 package built:
  • indilib
-- Found OpenGL: /nix/store/qmh5qmrxml57pmm156vrbbxh1pyygrgn-libGL-1.3.2/lib/libOpenGL.so
-- Looking for drand48
-- Looking for drand48 - found
-- Found ZLIB: /nix/store/63x53nvrc8f3g302ral5sczhjqc5pf0d-zlib-1.2.11/lib/libz.so (found version "1.2.11")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
CMake Error at cmake/modules/FindNova.cmake:56 (message):
  libnova not found.  Please install libnova development package.
Call Stack (most recent call first):
  kstars/CMakeLists.txt:1064 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-kstars.drv-0/kstars-7acc527/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-kstars.drv-0/kstars-7acc527/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/sa1n9zgzhpf1jr2jcs2wykizmlhc7aqc-kstars.drv' failed with exit code 1

@hjones2199
Copy link
Member Author

hjones2199 commented Nov 3, 2020 •
edited

Result of nixpkgs-review pr 102385 run on x86_64-linux 1
1 package failed to build:
1 package built:

-- Found OpenGL: /nix/store/qmh5qmrxml57pmm156vrbbxh1pyygrgn-libGL-1.3.2/lib/libOpenGL.so
-- Looking for drand48
-- Looking for drand48 - found
-- Found ZLIB: /nix/store/63x53nvrc8f3g302ral5sczhjqc5pf0d-zlib-1.2.11/lib/libz.so (found version "1.2.11")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
CMake Error at cmake/modules/FindNova.cmake:56 (message):
  libnova not found.  Please install libnova development package.
Call Stack (most recent call first):
  kstars/CMakeLists.txt:1064 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-kstars.drv-0/kstars-7acc527/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-kstars.drv-0/kstars-7acc527/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/sa1n9zgzhpf1jr2jcs2wykizmlhc7aqc-kstars.drv' failed with exit code 1

Latest commit fixes kstars (and updates it to 3.4.3). It also applies patches to support telescope control via the indilib binaries in the nix store.

@ofborg ofborg bot requested a review from TimPut November 3, 2020 00:47
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102385 run on x86_64-linux 1

2 packages built:
  • indilib
  • kstars

TimPut
TimPut approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@TimPut TimPut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me.

@alyssais alyssais merged commit 5041cbc into NixOS:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimPut TimPut TimPut approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hjones2199 @SuperSandro2000 @TimPut @alyssais