Skip to content

mediatomb: Allow users to customize duktape/js script imports #102393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mediatomb: Allow users to customize duktape/js script imports #102393

wants to merge 1 commit into from
+21 −3

Conversation

ardumont
Copy link
Contributor

@ardumont ardumont commented Nov 1, 2020 •
edited
Loading

Motivation

With no customization, the default behavior is kept (virtual-layout using the
builtin engine with the default import.js provided by gerbera).

This allows user to develop and provide their own list of customized
duktape/javascript scripts [1]

[1] http://docs.gerbera.io/en/latest/scripting.html

(supersedes #101296)

Actions

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS: odroid [2]
    • macOS
    • other Linux distributions: debian with nix
  • Tested via one or more NixOS test(s) [3]
  • nixpkgs-review wip [4]
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[2] https://gitlab.com/ardumont/nixos/-/blob/master/odroid/mediatomb/default.nix#L24

[3]

$ sudo chmod 666 /dev/kvm # for some reason otherwise permission denied (user is in kvm group though)
$ cd nixos/tests
$ nix-build mediatomb.nix
...
client # [   12.927208] reboot: Power down
(0.59 seconds)
(13.67 seconds)
test script finished in 13.67s
cleaning up
(0.00 seconds)
/nix/store/pxc71jg8vgra3iywvxljgsh20clfcn79-vm-test-run-mediatomb

[4]

$ nixpkgs-review pr 102393
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/102393/head:refs/nixpkgs-review/1
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 12 (delta 8), reused 8 (delta 8), pack-reused 2
Unpacking objects: 100% (12/12), 92.33 KiB | 373.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   02daf3f0768..9c87b3271a6  master                -> refs/nixpkgs-review/0
 + 7c389b0c3ff...ba9ade5c557 refs/pull/102393/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/tony/.cache/nixpkgs-review/pr-102393/nixpkgs 9c87b3271a6558f9adc60500424ca2a9e376a8c1
Preparing worktree (detached HEAD 9c87b3271a6)
Updating files: 100% (23083/23083), done.
HEAD is now at 9c87b3271a6 Merge pull request #102386 from seppeljordan/update-nix-prefetch-github-4.0
$ nix-env -f /home/tony/.cache/nixpkgs-review/pr-102393/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit ba9ade5c557138a69983fd100a6348ec8ab28ce4
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/tony/.cache/nixpkgs-review/pr-102393/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/102393
$ nix-shell /home/tony/.cache/nixpkgs-review/pr-102393/shell.nix

Sorry, something went wrong.

@ardumont
Copy link
Contributor Author

ardumont commented Nov 1, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Nov 1, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 1, 2020
@ardumont
mediatomb: Allow users to customize duktape/js script imports

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vdemeester Vincent Demeester
GPG key ID: 083CC6FD6EB699A3
Expired
Verified
Learn about vigilant mode
bf7ea83 
With no customization, the default behavior is kept (virtual-layout using the
builtin engine with the default import.js provided by gerbera).

This allows user to develop and provide their own list of customized
duktape/javascript scripts [1]

[1] http://docs.gerbera.io/en/latest/scripting.html
@ardumont ardumont force-pushed the mediatomb-custom-import branch from ba9ade5 to bf7ea83 Compare April 4, 2021 17:14
@ardumont
Copy link
Contributor Author

ardumont commented Apr 4, 2021

Rebase

@stale
Copy link

stale bot commented Oct 1, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2021
@timokau timokau removed the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Apr 16, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 16, 2022
@timokau
Copy link
Member

timokau commented Apr 16, 2022

Hi!

The marvin-mk2 bot is now discontinued. I have removed the relevant tags from this PR. If you still need someone to look at it, one option would be to ask in this discourse thread.

I am posting this notice to all open PRs with the marvin tag. Please understand that following all of these discussions would take too much time, so I will unsubscribe from this PR unless I have already been involved in it before this message.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 2, 2022
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ardumont @timokau @wegank