Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk: 1.8.0_265 -> 1.8.0_272 #102360

Merged
merged 1 commit into from Nov 4, 2020
Merged

openjdk: 1.8.0_265 -> 1.8.0_272 #102360

merged 1 commit into from Nov 4, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Nov 1, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
sh-4.4# result/bin/java -version
openjdk version "1.8.0_272"
OpenJDK Runtime Environment (build 1.8.0_272-b10)
OpenJDK 64-Bit Server VM (build 25.272-b10, mixed mode)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asbachb asbachb changed the title openjdk:openjdk8: 1.8.0_265 -> 1.8.0_272 openjdk: 1.8.0_265 -> 1.8.0_272 Nov 1, 2020
@asbachb
Copy link
Contributor Author

asbachb commented Nov 1, 2020

/cc @NeQuissimus

@ofborg ofborg bot requested a review from edwtjo November 1, 2020 16:31
@asbachb
Copy link
Contributor Author

asbachb commented Nov 3, 2020

/cc @Ma27

@asbachb
Copy link
Contributor Author

asbachb commented Nov 3, 2020

/marvin opt-in
/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 3, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 3, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 3, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@NeQuissimus NeQuissimus merged commit 41f017c into NixOS:master Nov 4, 2020
@asbachb asbachb deleted the update/openjdk8 branch November 4, 2020 15:18
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hash-mismatch-building-jre-on-release-20-09/9898/2

@asbachb
Copy link
Contributor Author

asbachb commented Dec 26, 2020

We know. Have a look at previous mentioned discourse thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500 marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asbachb @nixos-discourse @NeQuissimus