Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haxor-news: use python3, fix build #102391

Merged
merged 1 commit into from Nov 3, 2020
Merged

haxor-news: use python3, fix build #102391

merged 1 commit into from Nov 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2020 •
edited

Motivation for this change

related: #101964

also fixes build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2020
@jonringer
Copy link
Contributor Author

cc @matthiasbeyer

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102391 run on x86_64-darwin 1

1 package built:
  • haxor-news

@jonringer jonringer merged commit 7543833 into NixOS:master Nov 3, 2020
@erictapen
Copy link
Member

@jonringer Sure this is backport worthy? Builds for me on 20.09 and it doesn't seem to contain any security fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @SuperSandro2000 @erictapen @matthiasbeyer @FRidh