Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: dont wrap when configure is null #102367

Merged
merged 1 commit into from Nov 1, 2020
Merged

neovim: dont wrap when configure is null #102367

merged 1 commit into from Nov 1, 2020

Conversation

teto
Copy link
Member

@teto teto commented Nov 1, 2020 •
edited

restore previous behavior where you dont wrap when configure is null see #102297

@houstdav000 can you check it fixes the issue ?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyntheticfox
Copy link
Contributor

Looks to work 👍

@teto
neovim: dont wrap when is null
b75802e 
restore previous behavior
@teto teto merged commit 295948f into NixOS:master Nov 1, 2020
@teto teto deleted the neovim_fix branch November 1, 2020 17:56
ghedamat added a commit to ghedamat/nixfiles that referenced this pull request Jun 1, 2021
@ghedamat
x280 - hack around neovim nix load config bug
45d89ec 
see NixOS/nixpkgs#102367
although I'm not sure this is the cause yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @cyntheticfox