Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020-09-20 -> 2020.11.01.1 #102366

Merged
merged 1 commit into from Nov 1, 2020
Merged

youtube-dl: 2020-09-20 -> 2020.11.01.1 #102366

merged 1 commit into from Nov 1, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 1, 2020

Motivation for this change

New upstream release.

Changelog: https://gitlab.com/dstftw/youtube-dl/-/tags/2020.11.01.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2020
@SuperSandro2000
Copy link
Member

Do we know if the source is credible? Is this one of the old maintainers?

@ajs124
Copy link
Member

ajs124 commented Nov 1, 2020

Do we know if the source is credible? Is this one of the old maintainers?

The download link was and is from https://yt-dl.org, so it should be fine.

@ajs124
Copy link
Member

ajs124 commented Nov 1, 2020 •
edited

A test download fails like this, for me:

[nix-shell:~/.cache/nixpkgs-review/pr-102366]$ ./results/youtube-dl/bin/youtube-dl 'https://www.youtube.com/watch?v=UxxajLWwzqY'
Traceback (most recent call last):
  File "/nix/store/nr6lqsqaddwd6hkajzkf1c8sgi6nkqqz-python3.8-youtube-dl-2020.11.01.1/bin/.youtube-dl-wrapped", line 6, in <module>
    from youtube_dl import main
  File "/nix/store/0015hbvkw7srn735vgd6f0khafna8yrl-python3.7-youtube-dl-2020.11.01.1/lib/python3.7/site-packages/youtube_dl/__init__.py", line 15, in <module>
    from .options import (
  File "/nix/store/0015hbvkw7srn735vgd6f0khafna8yrl-python3.7-youtube-dl-2020.11.01.1/lib/python3.7/site-packages/youtube_dl/options.py", line 8, in <module>
    from .downloader.external import list_external_downloaders
  File "/nix/store/0015hbvkw7srn735vgd6f0khafna8yrl-python3.7-youtube-dl-2020.11.01.1/lib/python3.7/site-packages/youtube_dl/downloader/__init__.py", line 5, in <module>
    from .hls import HlsFD
  File "/nix/store/0015hbvkw7srn735vgd6f0khafna8yrl-python3.7-youtube-dl-2020.11.01.1/lib/python3.7/site-packages/youtube_dl/downloader/hls.py", line 6, in <module>
    from Crypto.Cipher import AES
  File "/nix/store/fvj3xigmi9f2pizdigyd86y4wq0phfak-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Cipher/__init__.py", line 27, in <module>
    from Crypto.Cipher._mode_ecb import _create_ecb_cipher
  File "/nix/store/fvj3xigmi9f2pizdigyd86y4wq0phfak-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Cipher/_mode_ecb.py", line 35, in <module>
    raw_ecb_lib = load_pycryptodome_raw_lib("Crypto.Cipher._raw_ecb", """
  File "/nix/store/fvj3xigmi9f2pizdigyd86y4wq0phfak-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/_raw_api.py", line 308, in load_pycryptodome_raw_lib
    raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.cpython-38-x86_64-linux-gnu.so': /nix/store/fvj3xigmi9f2pizdigyd86y4wq0phfak-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-38-x86_64-linux-gnu.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.abi3.so': /nix/store/fvj3xigmi9f2pizdigyd86y4wq0phfak-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.so': /nix/store/fvj3xigmi9f2pizdigyd86y4wq0phfak-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory

Edit: Apparently that's only the case in a nixpkgs-review shell, where PYTHONPATH is set to something that breaks this somehow, so disregard this.

@mweinelt

This comment has been minimized.

Sign in to view
@alyssais alyssais merged commit d7a1f5e into NixOS:master Nov 1, 2020
@mweinelt mweinelt deleted the ytdl branch November 1, 2020 18:25
This was referenced Nov 1, 2020
Merged
Merged
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Ma27 Ma27 Awaiting requested review from Ma27

@Phreedom Phreedom Awaiting requested review from Phreedom

@Enzime Enzime Awaiting requested review from Enzime

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @SuperSandro2000 @ajs124 @alyssais @erictapen