Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.py-multihash: 0.2.3 -> 1.0.0 #101801

Merged
merged 1 commit into from Nov 11, 2020
Merged

pythonPackages.py-multihash: 0.2.3 -> 1.0.0 #101801

merged 1 commit into from Nov 11, 2020

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Saw this failing on hydra, and decided to fix it.

the postPatch phase should be removed upon the next release, as explained in the comment.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Rakesh4G October 26, 2020 22:38
SuperSandro2000
SuperSandro2000 reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build on darwin:

Result of nixpkgs-review pr 101801 1

2 packages built:
  • python37Packages.py-multihash
  • python38Packages.py-multihash

Luflosi
Luflosi approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvarWithoutBones IvarWithoutBones force-pushed the fix-multihash branch 2 times, most recently from 3d14b67 to 0a05a32 Compare November 11, 2020 16:46
@IvarWithoutBones IvarWithoutBones changed the title pythonPackages.py-multihash: fix build pythonPackages.py-multihash: 0.2.3 -> 1.0.0 Nov 11, 2020
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 101801 1

2 packages built:
  • python37Packages.py-multihash
  • python38Packages.py-multihash

@mweinelt mweinelt merged commit 1da7e9e into NixOS:master Nov 11, 2020
@IvarWithoutBones IvarWithoutBones deleted the fix-multihash branch November 11, 2020 17:02
@IvarWithoutBones IvarWithoutBones mentioned this pull request Nov 11, 2020
Merged
10 tasks
Luflosi added a commit to Luflosi/nixpkgs that referenced this pull request Feb 8, 2021
@Luflosi
python3Packages.py-multihash: mark not broken
46229e4 
This was marked broken in NixOS#101636, which was merged into the staging branch. Later, the package was updated and fixed in NixOS#101801. When the staging branch was then merged into master, the package was marked as broken while actually being fixed.
This was referenced Feb 8, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Luflosi Luflosi Luflosi approved these changes

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IvarWithoutBones @mweinelt @SuperSandro2000 @Luflosi