Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndpi 2.8 -> 3.4 #101800

Merged
merged 1 commit into from Nov 25, 2020
Merged

ndpi 2.8 -> 3.4 #101800

merged 1 commit into from Nov 25, 2020

Conversation

cheriimoya
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124

@cheriimoya
Copy link
Contributor Author

seems like this will close #90909 and all cves of #92860 except the last?

SuperSandro2000
SuperSandro2000 reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on darwin.

ajs124
ajs124 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @takikawa

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101800 run on x86_64-linux 1

1 package built:
  • ndpi

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101800 run on x86_64-darwin 1

1 package built:
  • ndpi

@SuperSandro2000 SuperSandro2000 merged commit 5d6004a into NixOS:master Nov 25, 2020
@Pamplemousse Pamplemousse mentioned this pull request Mar 17, 2021
Closed
6 tasks
@cheriimoya cheriimoya deleted the ndpi branch April 13, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ajs124 ajs124 ajs124 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheriimoya @SuperSandro2000 @ajs124