New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openblas: 0.3.10 -> 0.3.12 #101780
openblas: 0.3.10 -> 0.3.12 #101780
Conversation
@@ -144,12 +144,6 @@ stdenv.mkDerivation rec { | |||
buildPackages.stdenv.cc | |||
]; | |||
|
|||
# Disable an optimisation which seems to cause issues, pending an | |||
# upstream fix: https://github.com/xianyi/OpenBLAS/issues/2496 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this appears to have been closed upstream
cc @FRidh |
Please test/build numpy, scipy, and octave. |
|
|
😢 that wasn't what I wanted |
858e5dc
to
f280a98
Compare
done. |
This needs a rebase. |
done |
Apparently this wasn't pushed, or at least GitHub still shows a conflict. |
f280a98
to
3b4cd4f
Compare
for real this time |
this breaks numpy for me, or at least now, it segfaults when running tests with 32 cores
testing now if turning down the cores helps |
can confirm that
|
interesting, not sure why mine just segfaults |
I'm not sure how this all works, but can we ask Hydra to build it for us? |
I think ofborg was able to build this for us. Still, this shouldn't be happening :( |
This PR did not bump the version attribute. I am a bit confused how all of you did run tests but not notice the hash mismatch. |
Reverted in 4e29151. |
Maybe it was lost in the rebase / force push? Does github record a history of pull requests somehow? |
Version was there in 858e5dc before the force push. |
Version number got lost in a force push upstream: NixOS#101780
🤦 sorry about that - that's what I get for trying to multitask as much as I was |
this backports the effect of the following commits from `master` to 20.09: * f52263c treewide: Start to break up static overlay * d1d536c openblas: 0.3.10 -> 0.3.12 * f715602 Revert "openblas: 0.3.10 -> 0.3.12" * 840c201 Merge pull request NixOS#101715 from r-ryantm/auto-update/openblas * e1a59dd openblas: 0.3.10 -> 0.3.12 * 4e29151 Revert "Merge pull request NixOS#101780 from glittershark/bump-openblas" * 3b4cd4f openblas: 0.3.10 -> 0.3.12 * 692d219 Merge staging-next into staging * 7902256 openblas: enable multiple outputs * 92d7b38 openblas: enable on ppc64le * 0137860 openblas: 0.3.12 -> 0.3.13 The motivation is to unbreak building `python36Packages.scipy` (see issue 92458)
Motivation for this change
Fixes #92458
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)