Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.wingpanel-indicator-bluetooth: 2.1.5 -> 2020-10-01 #101785

Merged
merged 1 commit into from Oct 26, 2020
Merged

pantheon.wingpanel-indicator-bluetooth: 2.1.5 -> 2020-10-01 #101785

merged 1 commit into from Oct 26, 2020

Conversation

kirelagin
Copy link
Member

Motivation for this change

I am not sure if it actually fixes the issue, since I don’t know how to reproduce it, it happens for me very randomly, but looking at the PR and the issue it all makes sense.

@worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: pantheon The Pantheon desktop environment label Oct 26, 2020
worldofpeace
worldofpeace suggested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version before was 2.1.5. Can we fix the commit message?

@worldofpeace
Copy link
Contributor

All the changes look good elementary/wingpanel-indicator-bluetooth@2.1.5...master. They could cut a release if they wanted since there's no major changes (so like change major version)

@kirelagin
Copy link
Member Author

The version before was 2.1.5. Can we fix the commit message?

Ooops. Fixed.

@kirelagin kirelagin changed the title pantheon.wingpanel-indicator-bluetooth: 2.28 -> 2020-10-01 pantheon.wingpanel-indicator-bluetooth: 2.1.5 -> 2020-10-01 Oct 26, 2020
@worldofpeace worldofpeace merged commit ce4f40e into NixOS:master Oct 26, 2020
@worldofpeace
Copy link
Contributor

backported to 20.09 in f8ac004.
Thanks for making this PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kirelagin @worldofpeace @SuperSandro2000