Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.myfitnesspal: fix build #101776

Merged
merged 1 commit into from Oct 26, 2020
Merged

[20.09] pythonPackages.myfitnesspal: fix build #101776

merged 1 commit into from Oct 26, 2020

Conversation

IvarWithoutBones
Copy link
Member

(cherry picked from commit 7cea883)
ZHF: #97479
PR to master: #101760

cc @mweinelt

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bhipple October 26, 2020 16:39
@mweinelt mweinelt merged commit 1541698 into NixOS:release-20.09 Oct 26, 2020
@IvarWithoutBones IvarWithoutBones deleted the backport-myfitnesspal branch October 26, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvarWithoutBones @mweinelt