vector: add sinks, sources and transforms as nixpkgs default features #101778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Thanks for including vector in nixpkgs.
I've only just started using vector, but I'd argue that the version built on Hydra should contain features "sources", "sinks" and "transforms" in order for it to be attractive to substitute from cache.nixos.org.
At first, this change raised the closure-size from 60MB -> 1217MB ! Apparently due to maxmindb.so including references to rustc. Since I have no easy way of debugging this nor testing geoip-transform for that matter, I decided to just patch out the geoip-transform from Cargo.toml for now. Not the best solution, but maybe safer than a blind
remove-references-to rustc
without knowing the consequences.Let me hear what you think. :)
cc @thoughtpolice
PS. without the geo-ip transform, the change in path size is:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)