Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector: add sinks, sources and transforms as nixpkgs default features #101778

Merged
merged 1 commit into from Nov 10, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Oct 26, 2020

Motivation for this change

Thanks for including vector in nixpkgs.

I've only just started using vector, but I'd argue that the version built on Hydra should contain features "sources", "sinks" and "transforms" in order for it to be attractive to substitute from cache.nixos.org.

At first, this change raised the closure-size from 60MB -> 1217MB ! Apparently due to maxmindb.so including references to rustc. Since I have no easy way of debugging this nor testing geoip-transform for that matter, I decided to just patch out the geoip-transform from Cargo.toml for now. Not the best solution, but maybe safer than a blind remove-references-to rustc without knowing the consequences.

Let me hear what you think. :)

cc @thoughtpolice

PS. without the geo-ip transform, the change in path size is:

# before
/nix/store/hr3lpixb226r1656dgavqilj2a4hh1m2-vector-0.10.0          62944896

# after
/nix/store/2fcf8pvm5nddvplk4i96njjlxswh252a-vector-0.10.0         109147488
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Don't include transform-geoip unless this feature is explicitly selected
@thoughtpolice thoughtpolice merged commit dd1b7e3 into NixOS:master Nov 10, 2020
@thoughtpolice
Copy link
Member

@johanot Sorry this took so long, thanks for the patch!

@johanot johanot deleted the vector-more-default-features branch November 11, 2020 11:56
@thoughtpolice thoughtpolice mentioned this pull request Nov 12, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants