docs: Add 'how to request merging rights' #101806
Conversation
| </para> | ||
| <orderedlist> | ||
| <listitem> | ||
| <para>Be active and well-known in the community</para> |
There was a problem hiding this comment.
Note that these are not officially accepted terms -- those are just what I, personally, would use to decide if I was the one in power.
There was a problem hiding this comment.
Fair. "well-known" isn't exactly quantifiable but it read better than that TODO...
|
Errmm, this makes me sad. Because it's the unsavory truth that I'm too proud to put "on paper". Still to vague to actually be a "how to" though. Currently it really is just that thread. |
|
So... scrap the numbered list and keep the link to the GitHub issue and original TODO? |
|
I feel like that TODO is a bit damaging. Can I perhaps ping some of the folks in the linked issue? Not looking for a verdict but more of a guideline. I believe new members to the community might seek the same. At a personal level, while I don't think I qualify just yet I'd like be able to transform this guideline into some kind of milestone I could aim at. |
I think it will be perfectly reasonable to at least put what happens currently. We owe it to people. |
|
I've removed the points and left the link to the discussion. |
| <para>Please note that contributors with commit rights unactive for more than | ||
| three months will have their commit rights revoked.</para> |
There was a problem hiding this comment.
While you're here, it might be worth mentioning https://github.com/NixOS/rfcs/blob/master/rfcs/0055-retired-committers.md - so the policy would be something along the lines of "Please note that per RFC #55, contributors with commit rights to nixpkgs who are inactive for more than a year will become retired contributors."
...but that's also possibly worth a separate CL.
There was a problem hiding this comment.
Happy to integrate that in here since we didn't quite reach a conclusion.
Also, as you mentioned RFC, I'm wondering if we should morph the current discussion into one.
Any comments on this from the more active members following this discussion?
There was a problem hiding this comment.
@worldofpeace @cole-h I'm keen for this PR not to stall - any input on the above?
|
I agree that being honest about current state is better than a TODO. Maybe this encourages someone to help out by improving the process, I'm unfortunately able to do only the minimal work to keep current status quo running. |
Linked also to the GitHub issue on how to become a committer
Motivation for this change
While looking for this information myself, I bumped into the TODO in the manual.
@cole-h provided the missing answer and the link to #50105
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)