New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulseaudio: hsphfpd implementation #101787
Conversation
@@ -26,6 +26,11 @@ in stdenv.mkDerivation rec { | |||
sha256 = "1p2ncvjz6alr9n3l5wvq2arqgc7xjs6dqyar1l9jp0z8cfgapkb8"; | |||
}; | |||
|
|||
patches = [ | |||
# ./config-after-first-failure.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a misstake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the description, it's a reference implementation, as well as the root MR request, https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/288
I'm not planning on ever getting this into shape, I can't tell any functionality difference between this over the normal pulseaudio, actually causes more instability for me.
But some people showed interest in it, thus why I created the draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to work on this, if I find time. One benefit would be having support for absolute volume levels, especially in conjunction with !239. Another would be bluetooth battery indicator but that still needs upower support.
a2cd3ed
to
09f9e30
Compare
03a2eca
to
1255466
Compare
@eadwu Enabling debug mode should be something like the following options: hardware.pulseaudio.daemon.logLevel = "debug";
systemd.services.bluetooth.serviceConfig.ExecStart = [ "" "${hardware.bluetooth.package}/libexec/bluetooth/bluetoothd -d" ]; |
No special reason, it's just since Pipewire also integrates with hsphfpd
90712ea
to
862dab9
Compare
I believe we can get this in a mergable state by adding a second duplicate pulseaudio derivation for the hsphfpd-patched version. Then we don't need to modify the default pulseaudio and don't cause any mass rebuilds. I'm currently running this and it seems to work fine. @eadwu Is it ok if I take over the PR and make changes along those lines? We want to get the hsphfpd part merged anyhow since apparently pipewire can use it as well now. |
Works fine for me. The reason why I used meson in the first place was because the autotools build was broken on my end. |
Hopefully, Pulseaudio 14 will be released before the end of the year and we will be able to switch to Meson in the main derivation. https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/milestones/1 |
New PR: #103225 |
Motivation for this change
Only meant as a reference implementation for testing
Closes: #87910
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)