tilp2: init at 1.18 #101796

luc65r · 2020-10-26T21:51:27Z

Motivation for this change

Things done

luc65r · 2020-10-26T21:53:29Z

@siraben could you check if tilem still works?

luc65r · 2020-10-26T21:56:43Z

I still have some problems with udev rules, as I need to lauch tilp as root: libusb couldn't open USB device /dev/bus/usb/001/007: Permission denied.
idVendor and idProduct are right.
Do I need to restart udev somehow?

SuperSandro2000

Build on darwin:

Result of nixpkgs-review pr 101796 1

2 packages failed to build:

gfm
tilp2

5 packages built:

libticables2
libticalcs2
libticonv
libtifiles2
tilem

builder for '/nix/store/ynmg6ysnlj0bi7z5bs4k0r8n3hbl26da-gfm-1.08.tar.bz2.drv'
failed with exit code 1; last 10 log lines:
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0                                                                                                              curl: (22) The requested URL returned error: 404 Not Found
trying https://kent.dl.sourceforge.net/sourceforge/gfm/gfm-1.08.tar.bz2
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0   300    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download gfm-1.08.tar.bz2 from any mirror
cannot build derivation '/nix/store/aarinffrgifh34baab8l8sfa0kfai5kp-gfm-1.08.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3rckmylybwxmc1am737f2hig5vh4sggc-tilp2-1.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pnvy2w07j67vjiyc5dgrwj3zp2lsacdx-env.drv': 2 dependencies couldn't be built

pkgs/applications/science/math/gfm/default.nix

pkgs/applications/science/math/tilp2/default.nix

pkgs/development/libraries/libticables2/default.nix

pkgs/development/libraries/libticalcs2/default.nix

pkgs/development/libraries/libtifiles2/default.nix

luc65r · 2020-10-27T12:19:29Z

@SuperSandro2000 Sorry, wrong link, I should have deleted the source in /nix/store to test it.
It should work now

SuperSandro2000 · 2020-10-27T12:34:38Z

Run on darwin:

Result of nixpkgs-review pr 101796 1

7 packages built:

gfm
libticables2
libticalcs2
libticonv
libtifiles2
tilem
tilp2

pkgs/applications/science/math/gfm/default.nix

luc65r · 2020-10-27T20:10:42Z

value is a set while a list was expected at libticalcs2/default.nix:47:33
Why does this line fail? platforms = with platforms; linux ++ darwin;
There is the same line in every other file!
I tested reverting this line on this file to platforms = platforms.linux ++ platforms.darwin;, and everything works!
WTF????

Firstly, it means the same thing.
Secondly, there are these with platforms; on every other file, and they work.

Either I'm blind or this is a bug with nix.

sikmir · 2020-10-27T21:05:00Z

Either I'm blind or this is a bug with nix.

No magic, you have darwin parameter on line 12.
To fix problem, use inherit (darwin) libobjc in all-packages.nix.

luc65r · 2020-10-27T21:13:06Z

I guess I'm blind then...

SuperSandro2000 · 2020-10-27T22:06:22Z

Run on darwin:

Result of nixpkgs-review pr 101796 1

7 packages built:

gfm
libticables2
libticalcs2
libticonv
libtifiles2
tilem
tilp2

mkg20001

nitpicks

pkgs/applications/science/math/gfm/default.nix

mkg20001 · 2020-11-02T20:52:13Z

pkgs/applications/science/math/gfm/default.nix

+  ];
+
+  buildInputs = [
+    gnome2.gtk


gtk2 or gtk3?

does this possibly need wrapGAppsHook (does this have an UI and does that ui work?)

It needs gtk2: checking for gtk+-2.0 >= 2.6.0.
It has an UI, and it does work, so I guess it doesn't need wrapGAppsHook

Is gtk2 and gnome2.gtk the same packages?

Yes, they are the same package.
In pkgs/desktops/gnome-2/default.nix:

gtk = pkgs.gtk2;

Then I would prefer using gtk2.

pkgs/applications/science/math/tilp2/default.nix

pkgs/development/libraries/libticonv/default.nix

pkgs/applications/science/math/tilp2/default.nix

pkgs/development/libraries/libtifiles2/default.nix

siraben · 2020-11-03T01:26:50Z

nixos/modules/programs/tilp2.nix

+  };
+
+  config = mkIf cfg.enable {
+    services.udev.packages = [


How come it has to be a NixOS module?

We can't enable udev rules any other way, can we?

siraben · 2020-11-22T03:15:34Z

Result of nixpkgs-review pr 101796 1

7 packages built:

gfm
libticables2
libticalcs2
libticonv
libtifiles2
tilem
tilp2

siraben · 2021-01-23T13:42:25Z

@luc65r please resolve the merge conflict.

pkgs/applications/science/math/gfm/default.nix

pkgs/applications/science/math/tilp2/default.nix

pkgs/development/libraries/libticables2/default.nix

pkgs/development/libraries/libticalcs2/default.nix

pkgs/development/libraries/libtifiles2/default.nix

pkgs/development/libraries/libticonv/default.nix

SuperSandro2000 · 2021-01-23T22:08:37Z

pkgs/applications/science/math/gfm/default.nix

+  ];
+
+  buildInputs = [
+    gnome2.gtk


Is gtk2 and gnome2.gtk the same packages?

SuperSandro2000 · 2021-01-23T23:17:02Z

@luc65r please fix the eval error.

siraben

LGTM. Thanks for doing this.

SuperSandro2000 · 2021-01-24T23:49:00Z

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101796 run on x86_64-darwin 1

7 packages built:

gfm
libticables2
libticalcs2
libticonv
libtifiles2
tilem
tilp2

SuperSandro2000 · 2021-01-24T23:54:43Z

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101796 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

7 packages built:

gfm
libticables2
libticalcs2
libticonv
libtifiles2
tilem
tilp2

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 26, 2020

luc65r force-pushed the pkg/tilp2 branch from b2d6a29 to 3c08cb7 Compare October 26, 2020 22:05

SuperSandro2000 requested changes Oct 26, 2020

View reviewed changes

siraben approved these changes Oct 27, 2020

View reviewed changes

luc65r force-pushed the pkg/tilp2 branch 2 times, most recently from 8e9a668 to b6dcbf8 Compare October 27, 2020 12:17

sikmir reviewed Oct 27, 2020

View reviewed changes

pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Oct 27, 2020

View reviewed changes

pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Oct 27, 2020

View reviewed changes

pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved

luc65r force-pushed the pkg/tilp2 branch from b6dcbf8 to e86fede Compare October 27, 2020 19:25

luc65r force-pushed the pkg/tilp2 branch from e86fede to 58d8d46 Compare October 27, 2020 21:12

luc65r force-pushed the pkg/tilp2 branch from 2d0ef5f to 941fd6e Compare November 2, 2020 20:37

ofborg bot added 6.topic: nixos 8.has: module (update) labels Nov 2, 2020

mkg20001 requested changes Nov 2, 2020

View reviewed changes

siraben reviewed Nov 3, 2020

View reviewed changes

luc65r force-pushed the pkg/tilp2 branch from 941fd6e to ff74679 Compare November 3, 2020 09:40

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

luc65r force-pushed the pkg/tilp2 branch from ff74679 to ba3ba6f Compare January 23, 2021 15:00

ofborg bot removed the 2.status: merge conflict label Jan 23, 2021

SuperSandro2000 requested changes Jan 23, 2021

View reviewed changes

luc65r added 7 commits January 24, 2021 13:57

libticonv: init at 1.1.5

3e51cd1

libtifiles2: init at 1.1.7

eadb35d

libticables2: init at 1.3.5

87d7a06

libticalcs2: init at 1.1.9

e69bd78

gfm: init at 1.08

99d0610

tilp2: init at 1.18

3c5f402

nixos/tilp2: init

1900b6e

luc65r force-pushed the pkg/tilp2 branch from ba3ba6f to 1900b6e Compare January 24, 2021 13:14

ofborg bot requested a review from siraben January 24, 2021 13:42

siraben approved these changes Jan 24, 2021

View reviewed changes

SuperSandro2000 merged commit a36bf6f into NixOS:master Jan 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tilp2: init at 1.18 #101796

tilp2: init at 1.18 #101796

luc65r commented Oct 26, 2020 •

edited

luc65r commented Oct 26, 2020

luc65r commented Oct 26, 2020

SuperSandro2000 left a comment •

edited

luc65r commented Oct 27, 2020

SuperSandro2000 commented Oct 27, 2020 •

edited

luc65r commented Oct 27, 2020

sikmir commented Oct 27, 2020 •

edited

luc65r commented Oct 27, 2020

SuperSandro2000 commented Oct 27, 2020 •

edited

mkg20001 left a comment

mkg20001 Nov 2, 2020

mkg20001 Nov 2, 2020

luc65r Nov 3, 2020

SuperSandro2000 Jan 23, 2021

luc65r Jan 24, 2021

SuperSandro2000 Jan 24, 2021

siraben Nov 3, 2020

luc65r Nov 3, 2020

siraben commented Nov 22, 2020

siraben commented Jan 23, 2021

SuperSandro2000 Jan 23, 2021

SuperSandro2000 commented Jan 23, 2021 •

edited

siraben left a comment

SuperSandro2000 commented Jan 24, 2021

SuperSandro2000 commented Jan 24, 2021

tilp2: init at 1.18 #101796

tilp2: init at 1.18 #101796

Conversation

luc65r commented Oct 26, 2020 • edited

Motivation for this change

Things done

luc65r commented Oct 26, 2020

luc65r commented Oct 26, 2020

SuperSandro2000 left a comment • edited

Choose a reason for hiding this comment

luc65r commented Oct 27, 2020

SuperSandro2000 commented Oct 27, 2020 • edited

luc65r commented Oct 27, 2020

sikmir commented Oct 27, 2020 • edited

luc65r commented Oct 27, 2020

SuperSandro2000 commented Oct 27, 2020 • edited

mkg20001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siraben commented Nov 22, 2020

siraben commented Jan 23, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 23, 2021 • edited

siraben left a comment

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 24, 2021

SuperSandro2000 commented Jan 24, 2021

luc65r commented Oct 26, 2020 •

edited

SuperSandro2000 left a comment •

edited

SuperSandro2000 commented Oct 27, 2020 •

edited

sikmir commented Oct 27, 2020 •

edited

SuperSandro2000 commented Oct 27, 2020 •

edited

SuperSandro2000 commented Jan 23, 2021 •

edited