Systemd with the remote feature enabled by default
#102448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds the libmicrohttpd as a `buildInput` when `withRemote` is true.
This test allows to ensure the systemd-journal-gatewayd service is responding correcly when the NixOS option `enableHttpGateway` is set. The test has not been added into the main systemd test because a graphical stack is not required (and rebuilding the graphical stack on systemd change is huge).
|
Locally rebased this on top of #102469, and successfully ran |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since ae896e0, Systemd is no longer compiled with the journal gatewayd service because of an incompatibility between Systemd and libmicrohttpd. However, thanks to some updates, it is now building fine!
Note also the NixOS option
services.systemd.enableHttpGatewayis currently broken and this PR fixes it.Things done
Set
withRemotetotrueby default insystemdand disable this feature insystemdMinimal.The test
systemd-journalhas been added to ensure thesystemd-journal-gatewaydis running correctly.This test is passing when #102156 is reverted (thanks @flokli for the build;)).
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)