Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

junit: remove (broken since 2015) #102423

Closed
wants to merge 1 commit into from
Closed

junit: remove (broken since 2015) #102423

wants to merge 1 commit into from

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

junit is broken since 5 years
the expression is trying to use ant and upstream project is using maven
anyway junit is usually installed via maven/gradle inside apps so why package it with nix ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
Copy link
Member

wamserma commented Nov 2, 2020

Doing a quick grep over nixpkgs, this seems fine once #98130 is merged.
nix-shell -p nixpkgs-review --run "nixpkgs-review 102423" will then tell.

@wamserma
Copy link
Member

wamserma commented Nov 2, 2020

ping @asbachb @raboof to have ppl more familiar with the Java environment on this PR

@asbachb
Copy link
Contributor

asbachb commented Nov 2, 2020

Basically it's not uncommon to package libraries like junit as system package. All big vendors are doing so (e.g. Ubuntu https://packages.ubuntu.com/search?keywords=junit&searchon=names&suite=focal&section=all).

In theory you could use junit as standalone application. But I guess that use case is rather uncommon.

raboof
raboof approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree typically you'd get junit via the build tool (maven/gradle/sbt/...).

While I guess I can see how in theory you could have a scenario where it'd be useful to have it in the distro, that seems pretty obscure. I wouldn't be opposed to introducing a fixed version of the derivation at some point (along with a strong use case), but I'm in favor of deleting the broken package now.

wamserma
wamserma suggested changes Nov 3, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Keep junixsocket, see #98130

@freezeboy
Copy link
Contributor Author

Oops, so this PR has to wait for your change before being merged

@SuperSandro2000
Copy link
Member

Closing since there is effort to update it.

@freezeboy freezeboy deleted the remove-junit branch November 25, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma requested changes

@raboof raboof raboof approved these changes

@asbachb asbachb asbachb approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@freezeboy @wamserma @asbachb @SuperSandro2000 @raboof