Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] kernel/linuxManualConfig: add variant metadata #102425

Merged
merged 2 commits into from Nov 2, 2020
Merged

[20.09] kernel/linuxManualConfig: add variant metadata #102425

merged 2 commits into from Nov 2, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 2, 2020 •
edited

Motivation for this change

related: #102005

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Jonathan Ringer added 2 commits November 1, 2020 20:42
@jonringer
Copy link
Contributor Author 

$ nix-env -f /home/jon/.cache/nixpkgs-review/pr-102425/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/102425
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-102425/shell.nix

@jonringer jonringer merged commit faee35a into NixOS:release-20.09 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer