Skip to content

python3Packages.pandas-datareader: init at 0.9.0 #102458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

python3Packages.pandas-datareader: init at 0.9.0 #102458

merged 1 commit into from
Nov 4, 2020
+36 −0

Conversation

evax
Copy link
Contributor

@evax evax commented Nov 2, 2020

Motivation for this change

Up to date remote data access for pandas, works for multiple versions of pandas.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@evax evax requested review from FRidh and jonringer as code owners November 2, 2020 09:24
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 2, 2020
@evax evax force-pushed the pandas-datareader-0.9.0 branch 3 times, most recently from 14cc9e4 to 1f877a9 Compare November 2, 2020 16:22
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 2, 2020 •
edited
Loading

Result of nixpkgs-review pr 102458 run on x86_64-darwin 1

1 package failed to build:
  • python27Packages.pandas-datareader
2 packages built:
  • python37Packages.pandas-datareader
  • python38Packages.pandas-datareader
installing
Executing pipInstallPhase
/private/tmp/nix-build-python2.7-pandas-datareader-0.9.0.drv-0/pandas-datareader-0.9.0/dist /private/tmp/nix-build-python2.7-pandas-datareader-0.9.0.drv-0/pandas-datareader-0.9.0
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Processing ./pandas_datareader-0.9.0-py2-none-any.whl
ERROR: Package 'pandas-datareader' requires a different Python: 2.7.18 not in '>=3.6'

@evax evax force-pushed the pandas-datareader-0.9.0 branch from 1f877a9 to 14944b1 Compare November 2, 2020 16:54
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102458 run on x86_64-linux 1

2 packages built:
  • python37Packages.pandas-datareader
  • python38Packages.pandas-datareader

@evax
Copy link
Contributor Author

evax commented Nov 3, 2020

@SuperSandro2000 I disabled python 2.7 so the darwin builds should work

jonringer
jonringer approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102458 1

2 packages built:
  • python37Packages.pandas-datareader
  • python38Packages.pandas-datareader

@jonringer jonringer merged commit ba588df into NixOS:master Nov 4, 2020
@jonringer
Copy link
Contributor

thanks @SuperSandro2000 for reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evax @SuperSandro2000 @jonringer